Skip to content

Commit 99609bb

Browse files
committed
appease the cops
Signed-off-by: Ben Abrams <[email protected]>
1 parent c2f5dc0 commit 99609bb

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

resources/oracle_install.rb

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
property :checksum, String, regex: /^[0-9a-f]{32}$|^[a-zA-Z0-9]{40,64}$/
2828
property :md5, String, regex: /^[0-9a-f]{32}$|^[a-zA-Z0-9]{40,64}$/
2929
property :app_home, String
30-
property :app_home_mode, Integer, default: 0755
30+
property :app_home_mode, Integer, default: 0o755
3131
property :bin_cmds, Array, default: []
3232
property :owner, String, default: 'root'
3333
property :group, String, default: lazy { node['root_group'] }
@@ -258,8 +258,19 @@ def download_direct_from_oracle(tarball_name, new_resource)
258258
converge_by('download oracle tarball straight from the server') do
259259
Chef::Log.debug 'downloading oracle tarball straight from the source'
260260
shell_out!(
261-
%(curl --fail --create-dirs -L --retry #{new_resource.retries} --retry-delay #{new_resource.retry_delay} --cookie "#{cookie}" #{new_resource.url} -o #{download_path} --connect-timeout #{new_resource.connect_timeout} #{proxy} ),
262-
timeout: new_resource.download_timeout
261+
%W(
262+
curl
263+
--fail
264+
--create-dirs
265+
-L
266+
--retry #{new_resource.retries}
267+
--retry-delay #{new_resource.retry_delay} --cookie "#{cookie}"
268+
#{new_resource.url}
269+
-o #{download_path}
270+
--connect-timeout #{new_resource.connect_timeout}
271+
#{proxy}
272+
).join(' '),
273+
timeout: new_resource.download_timeout
263274
)
264275
end
265276
# Can't verify anything with HTTP return codes from Oracle. For example, they return 200 for auth failure.

0 commit comments

Comments
 (0)