v11 Table Flip (#705)

* Remove testing with 9 and 10 as they are no long supported

* Refactor installation, configuration and service resources

1. Condense client_install, server_install and respository resource into
   a single install resource.

2. Remove service action from install to remove the ability to enter a
   pathological situation where the chef run will not complete due to
   the service not starting because of a config error but the config error
   is unable to be corrected to allow the service to start.

3. Refactor the server_conf resource to config and add
   load_current_value support.

4. Initial work to switch back to pg gem instead of shell_out for SQL
   controlled resources. (may revert)

[ci skip]

* Skip module disable on non-module platforms

* Move templates to default

* Add systemd unit drop-in if external PID is set

* Create pg_hba.conf parser class

* Update access resource to match

* Set desired_state on common properties

* Update templates

* Fix access auth_options comparison

* Update ident resource to use parser class

* Role

* Database

* Split libraries

* Extension

* Add database inspec test

* MDL config

* Chefspec fixup

* Reenable all kitchen test versions

* CI fixup

* Refactor libs

* Testing fixup

* Kitchen cookbook fixup

* CI shorten testing temporarily

* More kitchen test fixing

* Use exec_params where we can

* Test cookbook fixup

* Config set version desired state false

* Update version match regex for Debian platforms

* RHEL 7 needs epel to install

* Kitchen test locale fixup

* Libraries include refactor

* Test property update

* Install resource update

* Turns out we can update access entries

* Access test fixup

* Ident test fixup

* Disable sort on pg_hba entries

* Skip role password overwrite unless explicit

* Extension kitchen fixup

* Reenable multi converge for ident

* pg install refactor

* Make access test indempotent

* Reenable all CI suites

* Expand initdb locale testing platforms

* Skip database locale for v13

* Automatic version detection

* Fixup missing requires

* Expand default packages

* Accept version as an integer also

* Correct name properties in resources

* Initial docs update

* Support pg_hba file comments

* Add comment support for ident resources

* Further docs update

* Update upgrading file

* Update README chef required version

Fixes #702

* Formatting fixup

Author: bmhughes

.github/workflows/ci.yml

@@ -18,53 +18,40 @@ jobs:
       matrix:
         os:
           - 'almalinux-8'
-          - 'amazonlinux-2'
           - 'centos-7'
           - 'centos-stream-8'
+          - 'centos-stream-9'
           - 'debian-10'
           - 'debian-11'
           - 'rockylinux-8'
-          - 'ubuntu-1804'
           - 'ubuntu-2004'
+          - 'ubuntu-2204'
 
         suite:
-          - 'access-96'
-          - 'access-10'
           - 'access-11'
           - 'access-12'
-          - 'access-12'
-          - 'client-install-96'
-          - 'client-install-10'
+          - 'access-13'
+          - 'access-14'
+          - 'access-15'
           - 'client-install-11'
           - 'client-install-12'
           - 'client-install-13'
-          - 'client-multi-install'
+          - 'client-install-14'
+          - 'client-install-15'
           - 'extension-12'
           - 'extension-13'
+          - 'extension-14'
+          - 'extension-15'
           - 'ident-12'
           - 'ident-13'
-          - 'initdb-locale-13'
-          - 'repo-96'
-          - 'repo-10'
-          - 'repo-11'
-          - 'repo-12'
-          - 'repo-13'
-          - 'server-install-96'
-          - 'server-install-10'
+          - 'ident-14'
+          - 'ident-15'
+          - 'initdb-locale-15'
           - 'server-install-11'
           - 'server-install-12'
           - 'server-install-13'
-        exclude:
-          - os: amazonlinux-2
-            suite: initdb-locale-13
-          - os: debian-10
-            suite: initdb-locale-13
-          - os: debian-11
-            suite: initdb-locale-13
-          - os: ubuntu-1804
-            suite: initdb-locale-13
-          - os: ubuntu-2004
-            suite: initdb-locale-13
+          - 'server-install-14'
+          - 'server-install-15'
       fail-fast: false
 
     steps:

.mdlrc

@@ -1 +1 @@
-rules "~MD013", "~MD024"
+rules "~MD007", "~MD013", "~MD024"

Berksfile

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 source 'https://supermarket.chef.io'
 
 metadata

CHANGELOG.md

@@ -4,6 +4,17 @@ This file is used to list changes made in the last 3 major versions of the postg
 
 ## Unreleased
 
+- Major refactor, see [UPGRADING.md](UPGRADING.md)
+- Condense repository, client_install and server_install into common install resource with actions replacing the previous split resources.
+  - `:repository` action
+  - `:install` action
+  - `:client_install` action
+  - `:server_install` action
+- Refactor database, role (user) and extension resources to use pg gem for database access
+  - All `load_current_value` support
+- Rename user resource to role to match PostgreSQL (still aliased to `:postgresql_user`)
+- Update various resource properties to match PostgreSQL side
+
 ## 10.0.2 - *2022-12-04*
 
 Standardise files with files in sous-chefs/repo-management

README.md

@@ -31,22 +31,22 @@ We follow the currently supported versions listed on <https://www.postgresql.org
 
 ### Chef
 
-- Chef 15.3+
+- Chef 16
 
 ### Cookbook Dependencies
 
 - `yum` >= 7.2.0 (for `dnf_module` resource)
 
 ## Resources
 
-- [`postgresql_access`](documentation/access.md)
-- [`postgresql_client_install`](documentation/client_install.md)
-- [`postgresql_database`](documentation/database.md)
-- [`postgresql_extension`](documentation/extension.md)
-- [`postgresql_ident`](documentation/ident.md)
-- [`postgresql_server_conf`](documentation/server_conf.md)
-- [`postgresql_server_install`](documentation/server_install.md)
-- [`postgresql_user`](documentation/user.md)
+- [postgresql_access](documentation/postgresql_access.md)
+- [postgresql_config](documentation/postgresql_config.md)
+- [postgresql_database](documentation/postgresql_database.md)
+- [postgresql_extension](documentation/postgresql_extension.md)
+- [postgresql_ident](documentation/postgresql_ident.md)
+- [postgresql_install](documentation/postgresql_install.md)
+- [postgresql_role](documentation/postgresql_role.md)
+- [postgresql_service](documentation/postgresql_service.md)
 
 ## Contributors
 

UPGRADING.md

@@ -1,22 +1,40 @@
-# Upgrading from v6.0
+# Upgrading
+
+## Upgrading to v11.0
+
+Version 11 is a major refactor and will require wrapping cookbooks to be updated to match the resource changes.
+
+### Summary
+
+- All resources now provide `load_current_value` support so will report changes on converge and will fire notifications.
+  - To provide this, all database access has been switched back to using the `pg` gem
+- The `:client_install`, `:server_install` and `:repository` resources have been condensed into a single `:install` resource providing the same install functionality
+- Service actions have been removed from the install resource
+- The `:server_conf` resource have been renamed to `:config` and server configuration is expected to be passed as a Hash to the `:server_config` property
+  - This change has been made to support later PostgreSQL version where some configuration values may have been removed
+- A `:service` resource is provided to manage PostgreSQL service management
+- Various resource properties have been renamed to remove collisions and match the PostgreSQL documentation and system column names
+- The `:access` and `:ident` resources now use a persistent accumulator so removals require an explicit `:delete` action
+
+## Upgrading from v6.0
 
 From v7.0.0 of the postgresql cookbook we have removed all recipes and attributes from the cookbook.
 
-## Deprecations
+### Deprecations
 
-### Gem
+#### Gem
 
 Due to limitations in the gem compile process (libssl related) we have removed the pg_gem.
 
 We no longer support accessing the database via the gem, and internally use the cli.
 
-### PG Tune
+#### PG Tune
 
 We currently do not implement the PG Tune functionality.
 
 This may be added in a future release.
 
-## Major Changes
+### Major Changes
 
 Recipes are no longer supported so you should take a look at the examples in `test/cookbooks/test/recipes`
 

documentation/.gitkeep

@@ -0,0 +1,14 @@
+# Index
+
+[Back to resource list](../README.md#resources)
+
+## Resources
+
+- [postgresql_access](postgresql_access.md)
+- [postgresql_config](postgresql_config.md)
+- [postgresql_database](postgresql_database.md)
+- [postgresql_extension](postgresql_extension.md)
+- [postgresql_ident](postgresql_ident.md)
+- [postgresql_install](postgresql_install.md)
+- [postgresql_role](postgresql_role.md)
+- [postgresql_service](postgresql_service.md)