Merge pull request #1507 from ksss/ancestors-invalid-type-application

Support `InvalidTypeApplication` on `#update_env`

Author: soutaro

lib/steep/services/signature_service.rb

@@ -295,7 +295,7 @@ def update_env(updated_files, paths:)
 
           unless errors.empty?
             # Builder won't be used.
-            factory = AST::Types::Factory.new(builder: _ = nil)
+            factory = AST::Types::Factory.new(builder: RBS::DefinitionBuilder.new(env: env, ancestor_builder: builder))
             return errors.map {|error| Diagnostic::Signature.from_rbs_error(error, factory: factory) }
           end
 

smoke/diagnostics-rbs/invalid-type-application-class.rbs

@@ -0,0 +1,2 @@
+class InvalidTypeApplicationClass < String[String]
+end

smoke/diagnostics-rbs/invalid-type-application-module.rbs

@@ -0,0 +1,2 @@
+module InvalidTypeApplicationModule : String[int]
+end

smoke/diagnostics-rbs/test_expectations.yml

@@ -70,6 +70,30 @@
     severity: ERROR
     message: Cannot find a non-overloading definition of `foo` in `::InvalidMethodOverload`
     code: RBS::InvalidMethodOverload
+- file: invalid-type-application-class.rbs
+  diagnostics:
+  - range:
+      start:
+        line: 1
+        character: 36
+      end:
+        line: 1
+        character: 50
+    severity: ERROR
+    message: Type `::String` is not generic but used as a generic type with 1 arguments
+    code: RBS::InvalidTypeApplication
+- file: invalid-type-application-module.rbs
+  diagnostics:
+  - range:
+      start:
+        line: 1
+        character: 38
+      end:
+        line: 1
+        character: 49
+    severity: ERROR
+    message: Type `::String` is not generic but used as a generic type with 1 arguments
+    code: RBS::InvalidTypeApplication
 - file: invalid-type-application.rbs
   diagnostics:
   - range: