Skip to content

[Parity with C#] BotAdapter UpdateActivity method signature #54

@gasper-az

Description

@gasper-az

Is your feature request related to a problem? Please describe.
We've found some differences between the updateActivity method from BotAdapter in DotNet and JS SDK.

In the DotNet version (link here), the UpdateActivityAsync method returns a Task<ResourceResponce>, which allows us to access to the ResourceResponse properties, as its Id. However, in the JS version (link here), the method returns a Promise, which is a completely different behavior from the DotNet's implementation.

Describe the solution you'd like
Add a new implementation of the updateActivity in BotAdapter.ts which returns a Promise<ResourceResponse> for ensuring parity with the DotNet version.

Additional context
DotNet implementation:
image

JS implementation:
image

[enhancement]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions