Skip to content

Commit 1a2ba1d

Browse files
authored
perf(metadata): get graphql operation when available (api-platform#4522)
1 parent e9d0139 commit 1a2ba1d

32 files changed

+62
-73
lines changed

src/Bridge/Doctrine/Odm/State/CollectionProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public function provide(string $resourceClass, array $identifiers = [], ?string
6363

6464
$resourceMetadata = $this->resourceMetadataCollectionFactory->create($resourceClass);
6565
try {
66-
$operation = $context['operation'] ?? (isset($context['graphql_operation_name']) ? $resourceMetadata->getGraphQlOperation($operationName) : $resourceMetadata->getOperation($operationName));
66+
$operation = $context['operation'] ?? $resourceMetadata->getOperation($operationName);
6767
$attribute = $operation->getExtraProperties()['doctrine_mongodb'] ?? [];
6868
} catch (OperationNotFoundException $e) {
6969
$attribute = $resourceMetadata->getOperation(null, true)->getExtraProperties()['doctrine_mongodb'] ?? [];

src/Core/Bridge/Doctrine/MongoDbOdm/CollectionDataProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public function getCollection(string $resourceClass, string $operationName = nul
7878

7979
$resourceMetadata = $this->resourceMetadataFactory->create($resourceClass);
8080
try {
81-
$operation = $context['operation'] ?? (isset($context['graphql_operation_name']) ? $resourceMetadata->getGraphQlOperation($operationName) : $resourceMetadata->getOperation($operationName));
81+
$operation = $context['operation'] ?? $resourceMetadata->getOperation($operationName);
8282
$attribute = $operation->getExtraProperties()['doctrine_mongodb'] ?? [];
8383
} catch (OperationNotFoundException $e) {
8484
$attribute = $resourceMetadata->getOperation(null, true)->getExtraProperties()['doctrine_mongodb'] ?? [];

src/Core/Bridge/Doctrine/MongoDbOdm/Extension/FilterExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function applyToCollection(Builder $aggregationBuilder, string $resourceC
5858
{
5959
$resourceMetadata = $this->resourceMetadataFactory->create($resourceClass);
6060
try {
61-
$operation = isset($context['graphql_operation_name']) ? $resourceMetadata->getGraphQlOperation($operationName) : $resourceMetadata->getOperation($operationName);
61+
$operation = $resourceMetadata->getOperation($operationName);
6262
$resourceFilters = $operation->getFilters();
6363
} catch (OperationNotFoundException $e) {
6464
$resourceFilters = $resourceMetadata->getOperation(null, true)->getFilters();

src/Core/Bridge/Doctrine/MongoDbOdm/Extension/OrderExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public function applyToCollection(Builder $aggregationBuilder, string $resourceC
7272
} else {
7373
$metadata = $this->resourceMetadataFactory->create($resourceClass);
7474
try {
75-
$defaultOrder = isset($context['graphql_operation_name']) ? $metadata->getGraphQlOperation($operationName)->getOrder() : $metadata->getOperation($operationName)->getOrder();
75+
$defaultOrder = $metadata->getOperation($operationName)->getOrder();
7676
} catch (OperationNotFoundException $e) {
7777
$defaultOrder = $metadata->getOperation(null, true)->getOrder();
7878
}

src/Core/Bridge/Doctrine/MongoDbOdm/Extension/PaginationExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ public function getResult(Builder $aggregationBuilder, string $resourceClass, st
125125

126126
$resourceMetadata = $this->resourceMetadataFactory->create($resourceClass);
127127
try {
128-
$operation = $context['operation'] ?? (isset($context['graphql_operation_name']) ? $resourceMetadata->getGraphQlOperation($operationName) : $resourceMetadata->getOperation($operationName));
128+
$operation = $context['operation'] ?? $resourceMetadata->getOperation($operationName);
129129
$attribute = $operation->getExtraProperties()['doctrine_mongodb'] ?? [];
130130
} catch (OperationNotFoundException $e) {
131131
$attribute = $resourceMetadata->getOperation(null, true)->getExtraProperties()['doctrine_mongodb'] ?? [];

src/Core/Bridge/Doctrine/MongoDbOdm/SubresourceDataProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public function getSubresource(string $resourceClass, array $identifiers, array
9898

9999
$resourceMetadata = $this->resourceMetadataFactory->create($resourceClass);
100100
try {
101-
$operation = $context['operation'] ?? (isset($context['graphql_operation_name']) ? $resourceMetadata->getGraphQlOperation($operationName) : $resourceMetadata->getOperation($operationName));
101+
$operation = $context['operation'] ?? $resourceMetadata->getOperation($operationName);
102102
$attribute = $operation->getExtraProperties()['doctrine_mongodb'] ?? [];
103103
} catch (OperationNotFoundException $e) {
104104
$attribute = $resourceMetadata->getOperation()->getExtraProperties()['doctrine_mongodb'] ?? [];

src/Core/Bridge/Doctrine/Orm/Extension/EagerLoadingExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ private function apply(bool $collection, QueryBuilder $queryBuilder, QueryNameGe
121121
if ($this->resourceMetadataFactory instanceof ResourceMetadataCollectionFactoryInterface) {
122122
$resourceMetadataCollection = $this->resourceMetadataFactory->create($resourceClass);
123123
try {
124-
$operation = isset($context['graphql_operation_name']) ? $resourceMetadataCollection->getGraphQlOperation($operationName) : $resourceMetadataCollection->getOperation($operationName);
124+
$operation = $resourceMetadataCollection->getOperation($operationName);
125125
$forceEager = $operation->getForceEager() ?? $this->forceEager;
126126
$fetchPartial = $operation->getFetchPartial() ?? $this->fetchPartial;
127127
} catch (OperationNotFoundException $e) {

src/Core/Bridge/Doctrine/Orm/Extension/FilterEagerLoadingExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public function applyToCollection(QueryBuilder $queryBuilder, QueryNameGenerator
6565
if ($this->resourceMetadataFactory instanceof ResourceMetadataCollectionFactoryInterface) {
6666
$resourceMetadataCollection = $this->resourceMetadataFactory->create($resourceClass);
6767
try {
68-
$operation = isset($context['graphql_operation_name']) ? $resourceMetadataCollection->getGraphQlOperation($operationName) : $resourceMetadataCollection->getOperation($operationName);
68+
$operation = $resourceMetadataCollection->getOperation($operationName);
6969
$forceEager = $operation->getForceEager() ?? $this->forceEager;
7070
} catch (OperationNotFoundException $e) {
7171
// In some cases the operation may not exist

src/Core/Bridge/Doctrine/Orm/Extension/FilterExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public function applyToCollection(QueryBuilder $queryBuilder, QueryNameGenerator
7070
$resourceFilters = $resourceMetadata->getCollectionOperationAttribute($operationName, 'filters', [], true);
7171
} else {
7272
try {
73-
$operation = $context['operation'] ?? (isset($context['graphql_operation_name']) ? $resourceMetadata->getGraphQlOperation($operationName) : $resourceMetadata->getOperation($operationName));
73+
$operation = $context['operation'] ?? $resourceMetadata->getOperation($operationName);
7474
$resourceFilters = $operation->getFilters();
7575
} catch (OperationNotFoundException $e) {
7676
// In some cases the operation may not exist

src/Core/Bridge/Doctrine/Orm/Extension/OrderExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public function applyToCollection(QueryBuilder $queryBuilder, QueryNameGenerator
7070
if ($this->resourceMetadataFactory instanceof ResourceMetadataCollectionFactoryInterface) {
7171
$resourceMetadataCollection = $this->resourceMetadataFactory->create($resourceClass);
7272
try {
73-
$defaultOrder = isset($context['graphql_operation_name']) ? ($resourceMetadataCollection->getGraphQlOperation($operationName)->getOrder() ?? []) : ($resourceMetadataCollection->getOperation($operationName)->getOrder() ?? []);
73+
$defaultOrder = $resourceMetadataCollection->getOperation($operationName)->getOrder() ?? [];
7474
} catch (OperationNotFoundException $e) {
7575
// In some cases the operation may not exist
7676
$defaultOrder = [];

0 commit comments

Comments
 (0)