ci: fix tests (api-platform#5421)

* ci: fix tests

* ci: cs fixes

* ci: fix cs & phpstan

Author: soyuka

features/authorization/deny.feature

@@ -202,4 +202,3 @@ Feature: Authorization checking
     And I send a "GET" request to "/secured_dummies"
     Then the response status code should be 200
     And the response should contain "ownerOnlyProperty"
-

src/Core/Annotation/ApiFilter.php

@@ -54,7 +54,7 @@ final class ApiFilter
     public $arguments = [];
 
     /**
-     * @param string $filterClass
+     * @param mixed  $filterClass
      * @param string $id
      * @param string $strategy
      */
@@ -65,9 +65,9 @@ public function __construct(
         array $properties = [],
         array $arguments = []
     ) {
-        if (\is_array($filterClass)) { /** @phpstan-ignore-line Doctrine annotations */
+        if (\is_array($filterClass)) {
             $options = $filterClass;
-            $this->filterClass = $options['value'] ?? null; /* @phpstan-ignore-line Doctrine annotations */
+            $this->filterClass = $options['value'] ?? null;
             unset($options['value']);
 
             foreach ($options as $key => $value) {

src/Core/Annotation/ApiProperty.php

@@ -23,7 +23,9 @@
  * @Annotation
  *
  * @Target({"METHOD", "PROPERTY"})
+ *
  * @Attributes(
+ *
  *     @Attribute("deprecationReason", type="string"),
  *     @Attribute("fetchable", type="bool"),
  *     @Attribute("fetchEager", type="bool"),

src/Core/Annotation/ApiResource.php

@@ -23,7 +23,9 @@
  * @Annotation
  *
  * @Target({"CLASS"})
+ *
  * @Attributes(
+ *
  *     @Attribute("accessControl", type="string"),
  *     @Attribute("accessControlMessage", type="string"),
  *     @Attribute("attributes", type="array"),

src/Core/Annotation/ApiSubresource.php

@@ -21,7 +21,9 @@
  * @Annotation
  *
  * @Target({"METHOD", "PROPERTY"})
+ *
  * @Attributes(
+ *
  *     @Attribute("maxDepth", type="int"),
  * )
  */

src/Core/Identifier/IdentifierConverter.php

@@ -71,7 +71,7 @@ public function convert($data, string $class, array $context = []): array
                 try {
                     $identifiers[$parameter] = $identifierTransformer->denormalize($value, $type);
                     break;
-                } catch (InvalidIdentifierException $e) {
+                } catch (InvalidIdentifierException $e) { // @phpstan-ignore-line wrong choice of interface, was fixed in 3.0
                     throw new InvalidIdentifierException(sprintf('Identifier "%s" could not be denormalized.', $parameter), $e->getCode(), $e);
                 }
             }

src/JsonApi/Serializer/ItemNormalizer.php

@@ -237,7 +237,6 @@ protected function normalizeRelation($propertyMetadata, $relatedObject, string $
             }
 
             $normalizedRelatedObject = $this->serializer->normalize($relatedObject, $format, $context);
-            // @phpstan-ignore-next-line throwing an explicit exception helps debugging
             if (!\is_string($normalizedRelatedObject) && !\is_array($normalizedRelatedObject) && !$normalizedRelatedObject instanceof \ArrayObject && null !== $normalizedRelatedObject) {
                 throw new UnexpectedValueException('Expected normalized relation to be an IRI, array, \ArrayObject or null');
             }

src/Metadata/ApiFilter.php

@@ -82,7 +82,7 @@ public function __construct(
             $this->arguments = $arguments;
         }
 
-        if (!\is_string($this->filterClass)) {
+        if (!\is_string($this->filterClass)) { /* @phpstan-ignore-line Doctrine annotations */
             throw new InvalidArgumentException('This annotation needs a value representing the filter class.');
         }
 

src/Serializer/AbstractItemNormalizer.php

@@ -887,7 +887,6 @@ protected function normalizeRelation($propertyMetadata, $relatedObject, string $
             }
 
             $normalizedRelatedObject = $this->serializer->normalize($relatedObject, $format, $context);
-            // @phpstan-ignore-next-line throwing an explicit exception helps debugging
             if (!\is_string($normalizedRelatedObject) && !\is_array($normalizedRelatedObject) && !$normalizedRelatedObject instanceof \ArrayObject && null !== $normalizedRelatedObject) {
                 throw new UnexpectedValueException('Expected normalized relation to be an IRI, array, \ArrayObject or null');
             }

src/Serializer/CacheKeyTrait.php

@@ -34,11 +34,11 @@ private function getCacheKey(?string $format, array $context)
         unset($context['cache_key']); // avoid artificially different keys
 
         try {
-            return hash('xxh128', $format.serialize([
+            return hash('md5', $format.serialize([
                 'context' => $context,
                 'ignored' => $context[self::IGNORED_ATTRIBUTES] ?? $this->defaultContext[self::IGNORED_ATTRIBUTES],
             ]));
-        } catch (\Exception) {
+        } catch (\Exception $e) {
             // The context cannot be serialized, skip the cache
             return false;
         }