Skip to content

Commit 3cbb9a7

Browse files
authored
chore: remove phpstan false positive (api-platform#5316)
* chore: remove phpstan false positive * moar * foo
1 parent 5baea78 commit 3cbb9a7

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/Doctrine/Orm/Util/QueryBuilderHelper.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ public static function addJoinOnce(QueryBuilder $queryBuilder, QueryNameGenerato
4343
$query = "$alias.$association";
4444

4545
if (Join::LEFT_JOIN === $joinType || QueryChecker::hasLeftJoin($queryBuilder)) {
46-
$queryBuilder->leftJoin($query, $associationAlias, $conditionType, $condition); // @phpstan-ignore-line
46+
$queryBuilder->leftJoin($query, $associationAlias, $conditionType, $condition);
4747
} else {
48-
$queryBuilder->innerJoin($query, $associationAlias, $conditionType, $condition); // @phpstan-ignore-line
48+
$queryBuilder->innerJoin($query, $associationAlias, $conditionType, $condition);
4949
}
5050

5151
return $associationAlias;

src/Test/DoctrineMongoDbOdmSetup.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class DoctrineMongoDbOdmSetup
3939
public static function createAnnotationMetadataConfiguration(array $paths, bool $isDevMode = false, string $proxyDir = null, string $hydratorDir = null, Cache $cache = null): Configuration
4040
{
4141
$config = self::createConfiguration($isDevMode, $proxyDir, $hydratorDir, $cache);
42-
$config->setMetadataDriverImpl($config->newDefaultAnnotationDriver($paths)); // @phpstan-ignore-line
42+
$config->setMetadataDriverImpl($config->newDefaultAnnotationDriver($paths));
4343

4444
return $config;
4545
}

src/Test/DoctrineMongoDbOdmTestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public static function createTestDocumentManager($paths = [])
4040
$config->setHydratorDir(sys_get_temp_dir());
4141
$config->setProxyNamespace('SymfonyTests\Doctrine');
4242
$config->setHydratorNamespace('SymfonyTests\Doctrine');
43-
$config->setMetadataDriverImpl(new AnnotationDriver(new AnnotationReader(), $paths)); // @phpstan-ignore-line
43+
$config->setMetadataDriverImpl(new AnnotationDriver(new AnnotationReader(), $paths));
4444
if (method_exists($config, 'setMetadataCache')) {
4545
$config->setMetadataCache(new ArrayAdapter());
4646
} else {

tests/Doctrine/Orm/Extension/EagerLoadingExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -830,7 +830,7 @@ public function testApplyToCollectionWithExistingJoin(string $joinType): void
830830
$queryBuilderProphecy->getEntityManager()->willReturn($emProphecy);
831831
$queryBuilderProphecy->getDQLPart('join')->willReturn([
832832
'o' => [
833-
new Join($joinType, 'o.relatedDummy', 'existing_join_alias'), // @phpstan-ignore-line
833+
new Join($joinType, 'o.relatedDummy', 'existing_join_alias'),
834834
],
835835
]);
836836
$queryBuilderProphecy->getDQLPart('select')->willReturn([]);

0 commit comments

Comments
 (0)