start working on tests

Author: soyuka

tests/Action/EntrypointActionTest.php

@@ -15,9 +15,9 @@
 
 use ApiPlatform\Action\EntrypointAction;
 use ApiPlatform\Api\Entrypoint;
-use ApiPlatform\Tests\ProphecyTrait;
 use ApiPlatform\Metadata\Resource\Factory\ResourceNameCollectionFactoryInterface;
 use ApiPlatform\Metadata\Resource\ResourceNameCollection;
+use ApiPlatform\Tests\ProphecyTrait;
 use PHPUnit\Framework\TestCase;
 
 /**

tests/Action/ExceptionActionTest.php

@@ -14,16 +14,14 @@
 namespace ApiPlatform\Tests\Action;
 
 use ApiPlatform\Action\ExceptionAction;
-use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
-use ApiPlatform\Core\Metadata\Resource\ResourceMetadata;
-use ApiPlatform\Tests\ProphecyTrait;
 use ApiPlatform\Exception\InvalidArgumentException;
 use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Metadata\Get;
 use ApiPlatform\Metadata\HttpOperation;
 use ApiPlatform\Metadata\Operations;
 use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
 use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
+use ApiPlatform\Tests\ProphecyTrait;
 use DomainException;
 use PHPUnit\Framework\TestCase;
 use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
@@ -38,7 +36,6 @@
  * @author Amrouche Hamza <[email protected]>
  * @author Baptiste Meyer <[email protected]>
  *
- * @group legacy
  * @group time-sensitive
  */
 class ExceptionActionTest extends TestCase
@@ -69,62 +66,6 @@ public function testActionWithCatchableException()
         $this->assertTrue($response->headers->contains('X-Frame-Options', 'deny'));
     }
 
-    /**
-     * @dataProvider provideOperationExceptionToStatusCases
-     * @group legacy
-     */
-    public function testLegacyActionWithOperationExceptionToStatus(
-        array $globalExceptionToStatus,
-        ?array $resourceExceptionToStatus,
-        ?array $operationExceptionToStatus,
-        int $expectedStatusCode
-    ) {
-        $this->expectDeprecation('Since api-platform/core 2.7: Use "ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface" instead of "ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface".');
-
-        $exception = new DomainException();
-        $flattenException = FlattenException::create($exception);
-
-        $serializer = $this->prophesize(SerializerInterface::class);
-        $serializer->serialize($flattenException, 'jsonproblem', ['statusCode' => $expectedStatusCode])->willReturn('');
-
-        $resourceMetadataFactory = $this->prophesize(ResourceMetadataFactoryInterface::class);
-        $resourceMetadataFactory->create('Foo')->willReturn(new ResourceMetadata(
-            'Foo',
-            null,
-            null,
-            [
-                'operation' => null !== $operationExceptionToStatus ? ['exception_to_status' => $operationExceptionToStatus] : [],
-            ],
-            null,
-            null !== $resourceExceptionToStatus ? ['exception_to_status' => $resourceExceptionToStatus] : []
-        ));
-
-        $exceptionAction = new ExceptionAction(
-            $serializer->reveal(),
-            [
-                'jsonproblem' => ['application/problem+json'],
-                'jsonld' => ['application/ld+json'],
-            ],
-            $globalExceptionToStatus,
-            $resourceMetadataFactory->reveal()
-        );
-
-        $request = new Request();
-        $request->setFormat('jsonproblem', 'application/problem+json');
-        $request->attributes->replace([
-            '_api_resource_class' => 'Foo',
-            '_api_item_operation_name' => 'operation',
-        ]);
-
-        $response = $exceptionAction($flattenException, $request);
-
-        $this->assertSame('', $response->getContent());
-        $this->assertSame($expectedStatusCode, $response->getStatusCode());
-        $this->assertTrue($response->headers->contains('Content-Type', 'application/problem+json; charset=utf-8'));
-        $this->assertTrue($response->headers->contains('X-Content-Type-Options', 'nosniff'));
-        $this->assertTrue($response->headers->contains('X-Frame-Options', 'deny'));
-    }
-
     /**
      * @dataProvider provideOperationExceptionToStatusCases
      */

tests/Api/IdentifiersExtractorTest.php

@@ -15,14 +15,14 @@
 
 use ApiPlatform\Api\IdentifiersExtractor;
 use ApiPlatform\Api\ResourceClassResolverInterface;
-use ApiPlatform\Tests\ProphecyTrait;
 use ApiPlatform\Metadata\Get;
 use ApiPlatform\Metadata\HttpOperation;
 use ApiPlatform\Metadata\Link;
 use ApiPlatform\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
 use ApiPlatform\Metadata\Property\Factory\PropertyNameCollectionFactoryInterface;
 use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\Dummy;
+use ApiPlatform\Tests\ProphecyTrait;
 use PHPUnit\Framework\TestCase;
 
 /**

tests/Api/QueryParameterValidator/QueryParameterValidatorTest.php

@@ -15,9 +15,9 @@
 
 use ApiPlatform\Api\FilterInterface;
 use ApiPlatform\Api\QueryParameterValidator\QueryParameterValidator;
-use ApiPlatform\Tests\ProphecyTrait;
 use ApiPlatform\Exception\FilterValidationException;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\Dummy;
+use ApiPlatform\Tests\ProphecyTrait;
 use PHPUnit\Framework\TestCase;
 use Psr\Container\ContainerInterface;
 

tests/Doctrine/Common/State/PersistProcessorTest.php

@@ -13,11 +13,11 @@
 
 namespace ApiPlatform\Tests\Doctrine\Common\State;
 
-use ApiPlatform\Tests\ProphecyTrait;
 use ApiPlatform\Doctrine\Common\State\PersistProcessor;
 use ApiPlatform\Metadata\Get;
 use ApiPlatform\State\ProcessorInterface;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\Dummy;
+use ApiPlatform\Tests\ProphecyTrait;
 use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
 use Doctrine\ORM\Mapping\ClassMetadataInfo;
 use Doctrine\Persistence\ManagerRegistry;

tests/Doctrine/Common/State/RemoveProcessorTest.php

@@ -13,11 +13,11 @@
 
 namespace ApiPlatform\Tests\Doctrine\Common\State;
 
-use ApiPlatform\Tests\ProphecyTrait;
 use ApiPlatform\Doctrine\Common\State\RemoveProcessor;
 use ApiPlatform\Metadata\Delete;
 use ApiPlatform\State\ProcessorInterface;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\Dummy;
+use ApiPlatform\Tests\ProphecyTrait;
 use Doctrine\Persistence\ManagerRegistry;
 use Doctrine\Persistence\ObjectManager;
 use PHPUnit\Framework\TestCase;

tests/Doctrine/EventListener/PublishMercureUpdatesListenerTest.php

@@ -16,8 +16,6 @@
 use ApiPlatform\Api\IriConverterInterface;
 use ApiPlatform\Api\ResourceClassResolverInterface;
 use ApiPlatform\Api\UrlGeneratorInterface;
-use ApiPlatform\Core\Metadata\Resource\ResourceMetadata;
-use ApiPlatform\Tests\ProphecyTrait;
 use ApiPlatform\Doctrine\EventListener\PublishMercureUpdatesListener;
 use ApiPlatform\Exception\InvalidArgumentException;
 use ApiPlatform\GraphQl\Subscription\MercureSubscriptionIriGeneratorInterface as GraphQlMercureSubscriptionIriGeneratorInterface;
@@ -33,6 +31,7 @@
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyFriend;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyMercure;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyOffer;
+use ApiPlatform\Tests\ProphecyTrait;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\Event\OnFlushEventArgs;
 use Doctrine\ORM\UnitOfWork;
@@ -309,7 +308,9 @@ public function testPublishUpdate(): void
 
         $resourceMetadataFactoryProphecy = $this->prophesize(ResourceMetadataCollectionFactoryInterface::class);
 
-        $resourceMetadataFactoryProphecy->create(DummyMercure::class)->willReturn(new ResourceMetadata(null, null, null, null, null, ['mercure' => []]));
+        $resourceMetadataFactoryProphecy->create(DummyMercure::class)->willReturn(new ResourceMetadataCollection(Dummy::class, [(new ApiResource())->withOperations(new Operations([
+            'get' => (new Get())->withMercure([]),
+        ]))]));
 
         $resourceMetadataFactoryProphecy->create(Dummy::class)->willReturn(new ResourceMetadataCollection(Dummy::class, [(new ApiResource())->withOperations(new Operations([
             'get' => (new Get())->withMercure(['hub' => 'managed', 'enable_async_update' => false])->withNormalizationContext(['groups' => ['foo', 'bar']]),

tests/Doctrine/EventListener/PurgeHttpCacheListenerTest.php

@@ -16,7 +16,6 @@
 use ApiPlatform\Api\IriConverterInterface;
 use ApiPlatform\Api\ResourceClassResolverInterface;
 use ApiPlatform\Api\UrlGeneratorInterface;
-use ApiPlatform\Tests\ProphecyTrait;
 use ApiPlatform\Doctrine\EventListener\PurgeHttpCacheListener;
 use ApiPlatform\Exception\InvalidArgumentException;
 use ApiPlatform\Exception\ItemNotFoundException;
@@ -25,6 +24,7 @@
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\Dummy;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyNoGetOperation;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\RelatedDummy;
+use ApiPlatform\Tests\ProphecyTrait;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\Event\OnFlushEventArgs;
 use Doctrine\ORM\Event\PreUpdateEventArgs;

tests/Doctrine/EventListener/WriteListenerTest.php

@@ -13,9 +13,9 @@
 
 namespace ApiPlatform\Tests\Doctrine\EventListener;
 
-use ApiPlatform\Tests\ProphecyTrait;
 use ApiPlatform\Doctrine\EventListener\WriteListener;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\Dummy;
+use ApiPlatform\Tests\ProphecyTrait;
 use Doctrine\Persistence\ManagerRegistry;
 use Doctrine\Persistence\ObjectManager;
 use PHPUnit\Framework\TestCase;

tests/Doctrine/Odm/Extension/FilterExtensionTest.php

@@ -14,7 +14,6 @@
 namespace ApiPlatform\Tests\Doctrine\Odm\Extension;
 
 use ApiPlatform\Api\FilterInterface as ApiFilterInterface;
-use ApiPlatform\Tests\ProphecyTrait;
 use ApiPlatform\Doctrine\Odm\Extension\FilterExtension;
 use ApiPlatform\Doctrine\Odm\Filter\FilterInterface;
 use ApiPlatform\Metadata\ApiResource;
@@ -23,6 +22,7 @@
 use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
 use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
 use ApiPlatform\Tests\Fixtures\TestBundle\Document\Dummy;
+use ApiPlatform\Tests\ProphecyTrait;
 use Doctrine\ODM\MongoDB\Aggregation\Builder;
 use PHPUnit\Framework\TestCase;
 use Psr\Container\ContainerInterface;