Metadata (#36)

* test: fix Metadata tests

* test: remove legacy environments from Behat tests

* chore: remove deprecations from DeprecationMetadataTrait and rename it to SanitizeMetadataTrait

* chore: remove annotation support on Metadata

* fix: PHP CS

* fix: typo

* chore: remove SanitizeMetadataTrait

* chore: set PHP dependency to 8.1 in composer.json

* fix: PHP typo

Author: vincentchalamon

composer.json

@@ -13,7 +13,7 @@
         }
     ],
     "require": {
-        "php": ">=7.1",
+        "php": ">=8.1",
         "doctrine/inflector": "^1.0 || ^2.0",
         "fig/link-util": "^1.0",
         "psr/cache": "^1.0 || ^2.0 || ^3.0",

src/Metadata/Property/DeprecationMetadataTrait.php

@@ -100,17 +100,7 @@ private function createMetadata(ApiProperty $attribute, ApiProperty $propertyMet
         }
 
         foreach (get_class_methods(ApiProperty::class) as $method) {
-            if (
-                // TODO: remove these checks for deprecated methods in 3.0
-                'getAttribute' !== $method &&
-                'isChildInherited' !== $method &&
-                'getSubresource' !== $method &&
-                'getAttributes' !== $method &&
-                // end of deprecated methods
-
-                preg_match('/^(?:get|is)(.*)/', $method, $matches) &&
-                null !== $val = $attribute->{$method}()
-            ) {
+            if (preg_match('/^(?:get|is)(.*)/', $method, $matches) && null !== $val = $attribute->{$method}()) {
                 $propertyMetadata = $propertyMetadata->{"with{$matches[1]}"}($val);
             }
         }

src/Metadata/Property/Factory/AttributePropertyMetadataFactory.php

@@ -16,7 +16,6 @@
 use ApiPlatform\Exception\PropertyNotFoundException;
 use ApiPlatform\Metadata\ApiProperty;
 use ApiPlatform\Metadata\Extractor\PropertyExtractorInterface;
-use ApiPlatform\Metadata\Property\DeprecationMetadataTrait;
 use Symfony\Component\PropertyInfo\Type;
 
 /**
@@ -27,7 +26,6 @@
  */
 final class ExtractorPropertyMetadataFactory implements PropertyMetadataFactoryInterface
 {
-    use DeprecationMetadataTrait;
     private $extractor;
     private $decorated;
 
@@ -65,11 +63,6 @@ public function create(string $resourceClass, string $property, array $options =
         $apiProperty = new ApiProperty();
 
         foreach ($propertyMetadata as $key => $value) {
-            if ('subresource' === $key) {
-                trigger_deprecation('api-platform', '2.7', 'Using "subresource" is deprecated, declare another resource instead.');
-                continue;
-            }
-
             if ('builtinTypes' === $key && null !== $value) {
                 $value = array_map(function (string $builtinType): Type {
                     return new Type($builtinType);
@@ -83,10 +76,6 @@ public function create(string $resourceClass, string $property, array $options =
             }
         }
 
-        if (isset($propertyMetadata['attributes'])) {
-            $apiProperty = $this->withDeprecatedAttributes($apiProperty, $propertyMetadata['attributes']);
-        }
-
         return $apiProperty;
     }
 
@@ -127,10 +116,6 @@ private function update(ApiProperty $propertyMetadata, array $metadata): ApiProp
             $propertyMetadata = $propertyMetadata->{'with'.ucfirst($metadataKey)}($metadata[$metadataKey]);
         }
 
-        if (isset($metadata['attributes'])) {
-            $propertyMetadata = $this->withDeprecatedAttributes($propertyMetadata, $metadata['attributes']);
-        }
-
         return $propertyMetadata;
     }
 }

src/Metadata/Property/Factory/ExtractorPropertyMetadataFactory.php

@@ -32,10 +32,10 @@
 use ApiPlatform\Metadata\Patch;
 use ApiPlatform\Metadata\Post;
 use ApiPlatform\Metadata\Put;
-use ApiPlatform\Metadata\Resource\DeprecationMetadataTrait;
 use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
+use Symfony\Component\Serializer\NameConverter\CamelCaseToSnakeCaseNameConverter;
 
 /**
  * Creates a resource metadata from {@see ApiResource} annotations.
@@ -45,19 +45,19 @@
  */
 final class AttributesResourceMetadataCollectionFactory implements ResourceMetadataCollectionFactoryInterface
 {
-    use DeprecationMetadataTrait;
-
     private $defaults;
     private $decorated;
     private $logger;
     private $graphQlEnabled;
+    private $camelCaseToSnakeCaseNameConverter;
 
     public function __construct(ResourceMetadataCollectionFactoryInterface $decorated = null, LoggerInterface $logger = null, array $defaults = [], bool $graphQlEnabled = false)
     {
         $this->defaults = $defaults;
         $this->decorated = $decorated;
         $this->logger = $logger ?? new NullLogger();
         $this->graphQlEnabled = $graphQlEnabled;
+        $this->camelCaseToSnakeCaseNameConverter = new CamelCaseToSnakeCaseNameConverter();
     }
 
     /**
@@ -236,10 +236,8 @@ private function getOperationWithDefaults(ApiResource $resource, Operation $oper
      */
     private function addGlobalDefaults($operation)
     {
-        $extraProperties = $operation->getExtraProperties();
         foreach ($this->defaults as $key => $value) {
-            [$newKey, $value] = $this->getKeyValue($key, $value);
-            $upperKey = ucfirst($newKey);
+            $upperKey = ucfirst($this->camelCaseToSnakeCaseNameConverter->denormalize($key));
             $getter = 'get'.$upperKey;
 
             if (!method_exists($operation, $getter)) {