fix(symfony): metadata cache array adapter dev only (api-platform#4986)

* ignore api_platform.state.item_provider when Doctrine is not enabled (api-platform#4954)

* fix(symfony): metadata cache is broken in dev/prod

Co-authored-by: Dmitri Goosens <[email protected]>

Author: emmanuelballery

src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -486,16 +486,16 @@ private function registerGraphQlConfiguration(ContainerBuilder $container, array
 
     private function registerCacheConfiguration(ContainerBuilder $container): void
     {
-        if (!$container->hasParameter('kernel.debug') || !$container->getParameter('kernel.debug')) {
+        if ($container->hasParameter('kernel.debug') && $container->getParameter('kernel.debug')) {
+            $container->register('api_platform.cache.metadata.property', ArrayAdapter::class)->addTag('cache.pool');
+            $container->register('api_platform.cache.metadata.resource', ArrayAdapter::class)->addTag('cache.pool');
+            $container->register('api_platform.cache.metadata.resource_collection', ArrayAdapter::class)->addTag('cache.pool');
+            $container->register('api_platform.cache.route_name_resolver', ArrayAdapter::class)->addTag('cache.pool');
+            $container->register('api_platform.cache.identifiers_extractor', ArrayAdapter::class);
+            $container->register('api_platform.elasticsearch.cache.metadata.document', ArrayAdapter::class);
+        } else {
             $container->removeDefinition('api_platform.cache_warmer.cache_pool_clearer');
         }
-
-        $container->register('api_platform.cache.metadata.property', ArrayAdapter::class)->addTag('cache.pool');
-        $container->register('api_platform.cache.metadata.resource', ArrayAdapter::class)->addTag('cache.pool');
-        $container->register('api_platform.cache.metadata.resource_collection', ArrayAdapter::class)->addTag('cache.pool');
-        $container->register('api_platform.cache.route_name_resolver', ArrayAdapter::class)->addTag('cache.pool');
-        $container->register('api_platform.cache.identifiers_extractor', ArrayAdapter::class);
-        $container->register('api_platform.elasticsearch.cache.metadata.document', ArrayAdapter::class);
     }
 
     private function registerDoctrineOrmConfiguration(ContainerBuilder $container, array $config, XmlFileLoader $loader): void

src/Symfony/Bundle/Resources/config/state.xml

@@ -42,7 +42,7 @@
         <service id="ApiPlatform\State\Pagination\PaginationOptions" alias="api_platform.pagination_options" />
 
         <service id="ApiPlatform\State\CreateProvider" class="ApiPlatform\State\CreateProvider">
-            <argument type="service" id="api_platform.state.item_provider" />
+            <argument type="service" id="api_platform.state.item_provider" on-invalid="ignore" />
 
             <tag name="api_platform.state_provider" />
         </service>