allow no input data transformer

Author: mtarld

features/jsonld/input_output.feature

@@ -354,3 +354,25 @@ Feature: JSON-LD DTO input and output
     Then the response status code should be 400
     And the response should be in JSON
     And the JSON node "hydra:description" should be equal to "The input data is misformatted."
+
+  Scenario: Reset password through an input DTO without DataTransformer 
+    When I send a "POST" request to "/user-reset-password" with body:
+    """
+    {
+      "email": "[email protected]"
+    }
+    """
+    Then the response status code should be 201
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"
+    And the JSON node "email" should be equal to "[email protected]"
+
+  Scenario: Reset password with an invalid payload through an input DTO without DataTransformer 
+    And I send a "POST" request to "/user-reset-password" with body:
+    """
+    {
+      "email": "this is not an email"
+    }
+    """
+    Then the response status code should be 422
+    And the response should be in JSON

src/Serializer/AbstractItemNormalizer.php

@@ -226,36 +226,42 @@ public function denormalize($data, $class, $format = null, array $context = [])
             $normalizedData = is_scalar($data) ? [$data] : $this->prepareForDenormalization($data);
             $class = $this->getClassDiscriminatorResolvedClass($normalizedData, $class);
         }
+
         $resourceClass = $this->resourceClassResolver->getResourceClass($objectToPopulate, $class);
         $context['api_denormalize'] = true;
         $context['resource_class'] = $resourceClass;
 
-        if (null !== ($inputClass = $this->getInputClass($resourceClass, $context)) && null !== ($dataTransformer = $this->getDataTransformer($data, $resourceClass, $context))) {
-            $dataTransformerContext = $context;
+        if (null !== $inputClass = $this->getInputClass($resourceClass, $context)) {
+            if (null !== $dataTransformer = $this->getDataTransformer($data, $resourceClass, $context)) {
+                $dataTransformerContext = $context;
 
-            unset($context['input']);
-            unset($context['resource_class']);
+                unset($context['input']);
+                unset($context['resource_class']);
 
-            if (!$this->serializer instanceof DenormalizerInterface) {
-                throw new LogicException('Cannot denormalize the input because the injected serializer is not a denormalizer');
-            }
+                if (!$this->serializer instanceof DenormalizerInterface) {
+                    throw new LogicException('Cannot denormalize the input because the injected serializer is not a denormalizer');
+                }
 
-            if ($dataTransformer instanceof DataTransformerInitializerInterface) {
-                $context[AbstractObjectNormalizer::OBJECT_TO_POPULATE] = $dataTransformer->initialize($inputClass, $context);
-                $context[AbstractObjectNormalizer::DEEP_OBJECT_TO_POPULATE] = true;
-            }
+                if ($dataTransformer instanceof DataTransformerInitializerInterface) {
+                    $context[AbstractObjectNormalizer::OBJECT_TO_POPULATE] = $dataTransformer->initialize($inputClass, $context);
+                    $context[AbstractObjectNormalizer::DEEP_OBJECT_TO_POPULATE] = true;
+                }
 
-            try {
-                $denormalizedInput = $this->serializer->denormalize($data, $inputClass, $format, $context);
-            } catch (NotNormalizableValueException $e) {
-                throw new UnexpectedValueException('The input data is misformatted.', $e->getCode(), $e);
-            }
+                try {
+                    $denormalizedInput = $this->serializer->denormalize($data, $inputClass, $format, $context);
+                } catch (NotNormalizableValueException $e) {
+                    throw new UnexpectedValueException('The input data is misformatted.', $e->getCode(), $e);
+                }
+
+                if (!\is_object($denormalizedInput)) {
+                    throw new UnexpectedValueException('Expected denormalized input to be an object.');
+                }
 
-            if (!\is_object($denormalizedInput)) {
-                throw new UnexpectedValueException('Expected denormalized input to be an object.');
+                return $dataTransformer->transform($denormalizedInput, $resourceClass, $dataTransformerContext);
             }
 
-            return $dataTransformer->transform($denormalizedInput, $resourceClass, $dataTransformerContext);
+            $resourceClass = $inputClass;
+            $context['resource_class'] = $inputClass;
         }
 
         $supportsPlainIdentifiers = $this->supportsPlainIdentifiers();

tests/Fixtures/TestBundle/DataPersister/UserResetPasswordDataPersister.php

@@ -0,0 +1,41 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\DataPersister;
+
+use ApiPlatform\Core\DataPersister\DataPersisterInterface;
+use ApiPlatform\Tests\Fixtures\TestBundle\Dto\UserResetPasswordDto;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
+
+final class UserResetPasswordDataPersister implements DataPersisterInterface
+{
+    public function persist($data)
+    {
+        if ('[email protected]' === $data->email) {
+            return $data;
+        }
+
+        throw new NotFoundHttpException();
+    }
+
+    public function remove($data)
+    {
+        throw new \LogicException(sprintf('Unexpected "%s()" call.', __METHOD__));
+    }
+
+    public function supports($data): bool
+    {
+        return $data instanceof UserResetPasswordDto;
+    }
+}
+

tests/Fixtures/TestBundle/Dto/UserResetPasswordDto.php

@@ -0,0 +1,24 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\Dto;
+
+use Symfony\Component\Validator\Constraints as Assert;
+
+final class UserResetPasswordDto
+{
+    /**
+     * @Assert\Email
+     */
+    public $email;
+}

tests/Fixtures/TestBundle/Entity/UserResource.php

@@ -0,0 +1,37 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\Entity;
+
+use ApiPlatform\Core\Annotation\ApiResource;
+use ApiPlatform\Tests\Fixtures\TestBundle\Dto\UserResetPasswordDto;
+use Symfony\Component\Validator\Constraints as Assert;
+
+/**
+ * @ApiResource(
+ *     collectionOperations={
+ *         "user-reset-password"={
+ *             "method"="POST",
+ *             "path"="/user-reset-password",
+ *             "input"=UserResetPasswordDto::class
+ *         }
+ *     }
+ * )
+ */
+final class UserResource
+{
+    /**
+     * @Assert\NotBlank
+     */
+    public string $username;
+}

tests/Fixtures/app/config/config_test.yml

@@ -109,6 +109,12 @@ services:
         tags:
             -  { name: 'api_platform.data_persister' }
 
+    app.user_reset_password_data_persister:
+        class: ApiPlatform\Tests\Fixtures\TestBundle\DataPersister\UserResetPasswordDataPersister
+        public: false
+        tags:
+            -  { name: 'api_platform.data_persister' }
+
     app.graphql.query_resolver.dummy_custom_not_retrieved_item:
         class: 'ApiPlatform\Tests\Fixtures\TestBundle\GraphQl\Resolver\DummyCustomQueryNotRetrievedItemResolver'
         public: false