cache

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>

Author: sozercan

Core/Services/API/APICache.swift

@@ -31,6 +31,9 @@ final class APICache {
         static let playlist: TimeInterval = 30 * 60 // 30 minutes
         static let artist: TimeInterval = 60 * 60 // 1 hour
         static let search: TimeInterval = 2 * 60 // 2 minutes
+        static let library: TimeInterval = 5 * 60 // 5 minutes
+        static let lyrics: TimeInterval = 24 * 60 * 60 // 24 hours
+        static let songMetadata: TimeInterval = 30 * 60 // 30 minutes
     }
 
     /// Maximum number of cached entries before LRU eviction kicks in.

Core/Services/API/YTMusicClient.swift

@@ -194,7 +194,7 @@ final class YTMusicClient: YTMusicClientProtocol {
             "browseId": "FEmusic_liked_playlists",
         ]
 
-        let data = try await request("browse", body: body)
+        let data = try await request("browse", body: body, ttl: APICache.TTL.library)
         let playlists = PlaylistParser.parseLibraryPlaylists(data)
         logger.info("Parsed \(playlists.count) library playlists")
         return playlists
@@ -208,7 +208,7 @@ final class YTMusicClient: YTMusicClientProtocol {
             "browseId": "FEmusic_liked_videos",
         ]
 
-        let data = try await request("browse", body: body)
+        let data = try await request("browse", body: body, ttl: APICache.TTL.library)
         let detail = PlaylistParser.parsePlaylistDetail(data, playlistId: "LM")
         logger.info("Parsed \(detail.tracks.count) liked songs")
         return detail.tracks
@@ -312,7 +312,7 @@ final class YTMusicClient: YTMusicClientProtocol {
             "browseId": lyricsBrowseId,
         ]
 
-        let browseData = try await request("browse", body: browseBody)
+        let browseData = try await request("browse", body: browseBody, ttl: APICache.TTL.lyrics)
         let lyrics = parseLyrics(from: browseData)
         logger.info("Fetched lyrics for \(videoId): \(lyrics.isAvailable ? "available" : "unavailable")")
         return lyrics
@@ -406,7 +406,7 @@ final class YTMusicClient: YTMusicClientProtocol {
             "tunerSettingValue": "AUTOMIX_SETTING_NORMAL",
         ]
 
-        let data = try await request("next", body: body)
+        let data = try await request("next", body: body, ttl: APICache.TTL.songMetadata)
         return try parseSongMetadata(data, videoId: videoId)
     }
 
@@ -637,6 +637,8 @@ final class YTMusicClient: YTMusicClientProtocol {
 
         // Invalidate liked playlist cache so UI updates immediately
         APICache.shared.invalidate(matching: "browse:")
+        // Invalidate song metadata cache (next: endpoint)
+        APICache.shared.invalidate(matching: "next:")
     }
 
     /// Adds or removes a song from the user's library.
@@ -655,6 +657,10 @@ final class YTMusicClient: YTMusicClientProtocol {
 
         _ = try await request("feedback", body: body)
         logger.info("Successfully edited library status")
+
+        // Invalidate library and song metadata cache so UI updates
+        APICache.shared.invalidate(matching: "browse:")
+        APICache.shared.invalidate(matching: "next:")
     }
 
     /// Adds a playlist to the user's library using the like/like endpoint.

Tests/KasetTests/APICacheTests.swift

@@ -83,6 +83,38 @@ final class APICacheTests: XCTestCase {
         XCTAssertEqual(APICache.TTL.playlist, 30 * 60) // 30 minutes
         XCTAssertEqual(APICache.TTL.artist, 60 * 60) // 1 hour
         XCTAssertEqual(APICache.TTL.search, 2 * 60) // 2 minutes
+        XCTAssertEqual(APICache.TTL.library, 5 * 60) // 5 minutes
+        XCTAssertEqual(APICache.TTL.lyrics, 24 * 60 * 60) // 24 hours
+        XCTAssertEqual(APICache.TTL.songMetadata, 30 * 60) // 30 minutes
+    }
+
+    func testLyricsCacheNotInvalidatedByMutations() {
+        // Lyrics use browse: prefix but should NOT be invalidated by mutation operations
+        // This test verifies that invalidating next: prefix doesn't affect lyrics
+        cache.set(key: "browse:lyrics_abc123", data: ["text": "lyrics content"], ttl: APICache.TTL.lyrics)
+        cache.set(key: "next:song_abc123", data: ["title": "song"], ttl: APICache.TTL.songMetadata)
+
+        // Simulate mutation invalidation (like rateSong would do)
+        cache.invalidate(matching: "next:")
+
+        // Lyrics should still be cached (browse: prefix not invalidated)
+        XCTAssertNotNil(cache.get(key: "browse:lyrics_abc123"))
+        // Song metadata should be invalidated
+        XCTAssertNil(cache.get(key: "next:song_abc123"))
+    }
+
+    func testSongMetadataCacheInvalidatedByMutations() {
+        // Song metadata uses next: prefix and should be invalidated by mutations
+        cache.set(key: "next:song_abc123", data: ["title": "song"], ttl: APICache.TTL.songMetadata)
+        cache.set(key: "browse:home_section", data: ["section": "home"], ttl: APICache.TTL.home)
+
+        // Simulate mutation invalidation for both prefixes
+        cache.invalidate(matching: "browse:")
+        cache.invalidate(matching: "next:")
+
+        // Both should be invalidated
+        XCTAssertNil(cache.get(key: "next:song_abc123"))
+        XCTAssertNil(cache.get(key: "browse:home_section"))
     }
 
     func testCacheEntryIsExpired() {