cleanup

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>

Author: sozercan

Core/Models/Artist.swift

@@ -13,6 +13,12 @@ struct Artist: Identifiable, Codable, Hashable, Sendable {
         self.name = name
         self.thumbnailURL = thumbnailURL
     }
+
+    /// Whether this artist has a valid navigable ID (not a generated UUID).
+    /// YouTube Music artist IDs are channel IDs like "UCxxxxxxx" and don't contain hyphens.
+    var hasNavigableId: Bool {
+        !self.id.isEmpty && !self.id.contains("-")
+    }
 }
 
 extension Artist {

Core/Services/AI/FoundationModelsService.swift

@@ -3,40 +3,6 @@ import FoundationModels
 import Observation
 import os
 
-// MARK: - AISessionType
-
-/// Defines the type of AI session to create, each optimized for specific use cases.
-///
-/// Session types help organize the code and provide semantic meaning,
-/// but note that Apple's Foundation Models framework does not expose
-/// temperature control in macOS 26. All sessions use the system default.
-@available(macOS 26.0, *)
-enum AISessionType: String, CaseIterable, Sendable {
-    /// Quick command parsing (play, skip, queue, etc.)
-    /// Best for predictable structured output.
-    case command
-
-    /// Creative analysis (lyrics explanation, recommendations)
-    /// Best for more insightful, varied responses.
-    case analysis
-
-    /// Multi-turn conversation (future use)
-    /// Best for natural dialogue.
-    case conversational
-
-    /// Human-readable description for logging and debugging.
-    var description: String {
-        switch self {
-        case .command:
-            "Command parsing (structured output)"
-        case .analysis:
-            "Creative analysis (insightful responses)"
-        case .conversational:
-            "Conversational (multi-turn dialogue)"
-        }
-    }
-}
-
 // MARK: - FoundationModelsService
 
 /// Service for managing Apple Foundation Models integration.
@@ -208,26 +174,6 @@ final class FoundationModelsService {
         )
     }
 
-    // MARK: - Legacy Session Creation (Deprecated)
-
-    /// Creates a new language model session for a given task.
-    /// - Parameter instructions: System instructions for the session.
-    /// - Returns: A configured LanguageModelSession, or nil if unavailable.
-    @available(*, deprecated, message: "Use createAnalysisSession or createCommandSession for better optimization")
-    func createSession(instructions: String) -> LanguageModelSession? {
-        self.createAnalysisSession(instructions: instructions)
-    }
-
-    /// Creates a session with tool access for grounded responses.
-    /// - Parameters:
-    ///   - instructions: System instructions for the session.
-    ///   - tools: Tools the model can use during generation.
-    /// - Returns: A configured LanguageModelSession with tools, or nil if unavailable.
-    @available(*, deprecated, message: "Use createCommandSession for tool-based sessions")
-    func createSession(instructions: String, tools: [any Tool]) -> LanguageModelSession? {
-        self.createCommandSession(instructions: instructions, tools: tools)
-    }
-
     /// Clears any cached session state.
     /// This can help if the model gets into a bad state.
     func clearContext() {

Core/ViewModels/ArtistDetailViewModel.swift

@@ -15,6 +15,9 @@ final class ArtistDetailViewModel {
     /// Whether a subscription operation is in progress.
     private(set) var isSubscribing: Bool = false
 
+    /// Error message from subscription toggle (nil if no error).
+    private(set) var subscriptionError: String?
+
     /// Whether to show all songs instead of limited preview.
     var showAllSongs: Bool = false
 
@@ -94,6 +97,7 @@ final class ArtistDetailViewModel {
         }
 
         self.isSubscribing = true
+        self.subscriptionError = nil
         defer { isSubscribing = false }
 
         do {
@@ -107,6 +111,7 @@ final class ArtistDetailViewModel {
                 self.logger.info("Subscribed to artist: \(detail.name)")
             }
         } catch {
+            self.subscriptionError = "Failed to update subscription. Please try again."
             self.logger.error("Failed to toggle subscription: \(error.localizedDescription)")
         }
     }

Tests/KasetTests/FoundationModelsServiceTests.swift

@@ -126,28 +126,3 @@ struct FoundationModelsServiceTests {
         service.clearContext()
     }
 }
-
-// MARK: - AISessionTypeExtendedTests
-
-@available(macOS 26.0, *)
-@Suite("AISessionType Extended", .tags(.api))
-struct AISessionTypeExtendedTests {
-    @Test(
-        "All session types have descriptions",
-        arguments: [
-            AISessionType.command,
-            AISessionType.analysis,
-            AISessionType.conversational,
-        ]
-    )
-    func allSessionTypesHaveDescriptions(type: AISessionType) {
-        let description = type.description
-        #expect(!description.isEmpty)
-    }
-
-    @Test("AISessionType is CaseIterable")
-    func sessionTypeIsCaseIterable() {
-        let allCases = AISessionType.allCases
-        #expect(allCases.count == 3)
-    }
-}

Tests/KasetTests/PlayerServiceTests.swift

@@ -9,6 +9,9 @@ struct PlayerServiceTests {
     var playerService: PlayerService
 
     init() {
+        // Reset UserDefaults to ensure clean initial state for tests
+        UserDefaults.standard.removeObject(forKey: "playerVolume")
+        UserDefaults.standard.removeObject(forKey: "playerVolumeBeforeMute")
         self.playerService = PlayerService()
     }
 

Tests/KasetTests/SearchResponseTests.swift

@@ -82,11 +82,12 @@ struct SearchResponseTests {
         #expect(item.subtitle == "Album Artist")
     }
 
-    @Test("Artist result item subtitle")
+    @Test("Artist result item subtitle is nil")
     func artistResultItemSubtitle() {
         let artist = Artist(id: "1", name: "Artist Name")
         let item = SearchResultItem.artist(artist)
-        #expect(item.subtitle == "Artist")
+        // Artist subtitle is nil because resultType already shows "Artist"
+        #expect(item.subtitle == nil)
     }
 
     @Test("Playlist result item subtitle")

Views/macOS/CommandBarView.swift

@@ -71,6 +71,7 @@ struct CommandBarView: View {
                             .foregroundStyle(.secondary)
                     }
                     .buttonStyle(.plain)
+                    .accessibilityLabel("Clear input")
                 }
             }
             .padding(.horizontal, 16)

Views/macOS/LikedMusicView.swift

@@ -276,7 +276,7 @@ struct LikedMusicView: View {
             Divider()
 
             // Go to Artist - show first artist with valid ID
-            if let artist = song.artists.first(where: { !$0.id.isEmpty && $0.id != UUID().uuidString }) {
+            if let artist = song.artists.first(where: { $0.hasNavigableId }) {
                 NavigationLink(value: artist) {
                     Label("Go to Artist", systemImage: "person")
                 }

Views/macOS/LyricsView.swift

@@ -87,6 +87,7 @@ struct LyricsView: View {
                 .buttonStyle(.plain)
                 .foregroundStyle(self.showExplanation ? .purple : .secondary)
                 .help("Explain lyrics with AI")
+                .accessibilityLabel(self.showExplanation ? "Hide lyrics explanation" : "Explain lyrics with AI")
                 .requiresIntelligence()
                 .disabled(self.isExplaining)
             }

Views/macOS/PlaylistDetailView.swift

@@ -329,7 +329,7 @@ struct PlaylistDetailView: View {
             Divider()
 
             // Go to Artist - show first artist with valid ID
-            if let artist = track.artists.first(where: { !$0.id.isEmpty && $0.id != UUID().uuidString }) {
+            if let artist = track.artists.first(where: { $0.hasNavigableId }) {
                 NavigationLink(value: artist) {
                     Label("Go to Artist", systemImage: "person")
                 }
@@ -487,6 +487,7 @@ private struct RefinePlaylistSheet: View {
                         .foregroundStyle(.secondary)
                 }
                 .buttonStyle(.plain)
+                .accessibilityLabel("Close")
             }
             .padding()