perf: optimize network, caching, and SwiftUI rendering (#57)

Author: sozercan

AGENTS.md

@@ -257,8 +257,12 @@ Before completing non-trivial features, verify:
 - [ ] Lists use `LazyVStack`/`LazyHStack` for large datasets
 - [ ] Network calls cancelled on view disappear (`.task` handles this)
 - [ ] Parsers have `measure {}` tests if processing large payloads
-- [ ] Images use `ImageCache` (not loading inline)
+- [ ] Images use `ImageCache` with appropriate `targetSize` (not loading inline)
 - [ ] Search input is debounced (not firing on every keystroke)
+- [ ] ForEach uses stable identity (avoid `Array(enumerated())` unless rank is needed)
+- [ ] Frequently updating UI (e.g., progress) caches formatted strings
+
+> 📚 See [docs/architecture.md#performance-guidelines](docs/architecture.md#performance-guidelines) for detailed patterns.
 
 ## Task Planning: Phases with Exit Criteria
 

Core/Services/API/APICache.swift

@@ -39,9 +39,19 @@ final class APICache {
     /// Maximum number of cached entries before LRU eviction kicks in.
     private static let maxEntries = 50
 
-    private var cache: [String: CacheEntry] = [:]
+    /// Pre-allocated dictionary with initial capacity to reduce rehashing.
+    private var cache: [String: CacheEntry]
 
-    private init() {}
+    /// Timestamp of last eviction to avoid running on every access.
+    private var lastEvictionTime: Date = .distantPast
+
+    /// Minimum interval between automatic evictions (30 seconds).
+    private static let evictionInterval: TimeInterval = 30
+
+    private init() {
+        // Pre-allocate capacity to avoid rehashing during normal operation
+        self.cache = Dictionary(minimumCapacity: Self.maxEntries)
+    }
 
     /// Gets cached data if available and not expired.
     func get(key: String) -> [String: Any]? {
@@ -61,15 +71,20 @@ final class APICache {
     /// Stores data in the cache with the specified TTL.
     /// Evicts least recently used entries if cache is at capacity.
     func set(key: String, data: [String: Any], ttl: TimeInterval) {
-        // Evict expired entries first
-        self.evictExpiredEntries()
+        let now = Date()
+
+        // Evict expired entries periodically (not on every set)
+        if now.timeIntervalSince(self.lastEvictionTime) > Self.evictionInterval {
+            self.evictExpiredEntries()
+            self.lastEvictionTime = now
+        }
 
         // Evict LRU entries if still at capacity
         while self.cache.count >= Self.maxEntries {
             self.evictLeastRecentlyUsed()
         }
 
-        self.cache[key] = CacheEntry(data: data, timestamp: Date(), ttl: ttl)
+        self.cache[key] = CacheEntry(data: data, timestamp: now, ttl: ttl)
     }
 
     /// Generates a stable, deterministic cache key from endpoint and request body.

Core/Services/API/YTMusicClient.swift

@@ -60,6 +60,14 @@ final class YTMusicClient: YTMusicClientProtocol {
             "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 Safari/605.1.15",
             "Accept-Encoding": "gzip, deflate, br",
         ]
+        // Increase connection pool for parallel requests (HTTP/2 multiplexing is automatic)
+        configuration.httpMaximumConnectionsPerHost = 6
+        // Use shared URL cache for transport-level caching
+        configuration.urlCache = URLCache.shared
+        configuration.requestCachePolicy = .useProtocolCachePolicy
+        // Reduce timeout for faster failure detection
+        configuration.timeoutIntervalForRequest = 15
+        configuration.timeoutIntervalForResource = 30
         self.session = URLSession(configuration: configuration)
     }
 
@@ -1203,8 +1211,10 @@ final class YTMusicClient: YTMusicClientProtocol {
         // Handle errors back on main actor
         switch result {
         case let .success(data):
-            // Parse JSON - URLSession already decompresses gzip/deflate on a background thread,
-            // and JSONSerialization is very fast for typical response sizes (~5-15ms)
+            // Parse JSON synchronously - JSONSerialization is highly optimized
+            // and typically completes in <5ms even for large responses.
+            // The actual response parsing (in Parsers/) is more expensive
+            // but must happen on MainActor anyway for @Observable updates.
             guard let json = try JSONSerialization.jsonObject(with: data) as? [String: Any] else {
                 throw YTMusicError.parseError(message: "Response is not a JSON object")
             }

Core/Services/WebKit/WebKitManager.swift

@@ -155,7 +155,7 @@ final class WebKitManager: NSObject, WebKitManagerProtocol {
     private var cookieDebounceTask: Task<Void, Never>?
 
     /// Minimum interval between cookie backup operations (in seconds).
-    private static let cookieDebounceInterval: Duration = .seconds(2)
+    private static let cookieDebounceInterval: Duration = .seconds(5)
 
     /// The YouTube Music origin URL.
     static let origin = "https://music.youtube.com"

Core/Utilities/ImageCache.swift

@@ -99,28 +99,38 @@ actor ImageCache {
     }
 
     /// Prefetches images with controlled concurrency to avoid network congestion.
+    /// Supports cooperative cancellation from SwiftUI's structured concurrency.
     /// - Parameters:
     ///   - urls: URLs to prefetch.
     ///   - targetSize: Optional target size for downsampling.
     ///   - maxConcurrent: Maximum number of concurrent fetches (default: 4).
-    func prefetch(urls: [URL], targetSize: CGSize? = nil, maxConcurrent: Int = maxConcurrentPrefetch)
-        async
-    {
+    func prefetch(urls: [URL], targetSize: CGSize? = nil, maxConcurrent: Int = maxConcurrentPrefetch) async {
+        // Use structured concurrency directly - cancellation propagates automatically
+        // when SwiftUI's .task is cancelled (view disappears or id changes)
         await withTaskGroup(of: Void.self) { group in
             var inProgress = 0
             for url in urls {
+                // Check cancellation before starting new work
+                guard !Task.isCancelled else { break }
+
+                // Skip if already in memory cache
+                if self.memoryCache.object(forKey: url as NSURL) != nil {
+                    continue
+                }
+
                 // Wait for a slot if we're at capacity
                 if inProgress >= maxConcurrent {
                     await group.next()
                     inProgress -= 1
                 }
 
                 group.addTask(priority: .utility) {
+                    guard !Task.isCancelled else { return }
                     _ = await self.image(for: url, targetSize: targetSize)
                 }
                 inProgress += 1
             }
-            // Wait for remaining tasks
+            // Wait for remaining tasks (will be cancelled if parent is cancelled)
             await group.waitForAll()
         }
     }

Views/macOS/CachedAsyncImage.swift

@@ -30,9 +30,16 @@ struct CachedAsyncImage<Content: View, Placeholder: View>: View {
                 self.placeholder()
             }
         }
+        .onChange(of: self.url) { _, _ in
+            // Reset state when URL changes for proper UX
+            self.image = nil
+            self.isLoaded = false
+        }
         .task(id: self.url) {
             guard let url else { return }
-            self.image = await ImageCache.shared.image(for: url, targetSize: self.targetSize)
+            let loadedImage = await ImageCache.shared.image(for: url, targetSize: self.targetSize)
+            guard !Task.isCancelled else { return }
+            self.image = loadedImage
             self.isLoaded = true
         }
     }

Views/macOS/HomeView.swift

@@ -71,10 +71,9 @@ struct HomeView: View {
                     .staggeredAppearance(index: 0)
                 }
 
-                // API sections
-                ForEach(Array(self.viewModel.sections.enumerated()), id: \.element.id) { index, section in
+                // API sections - use stable id without array enumeration
+                ForEach(self.viewModel.sections) { section in
                     self.sectionView(section)
-                        .staggeredAppearance(index: self.favoritesManager.isVisible ? index + 1 : index)
                         .task {
                             await self.prefetchImagesAsync(for: section)
                         }
@@ -93,6 +92,7 @@ struct HomeView: View {
 
             ScrollView(.horizontal, showsIndicators: false) {
                 LazyHStack(spacing: 16) {
+                    // Use stable ID from items, avoid enumeration for non-chart sections
                     if section.isChart {
                         ForEach(Array(section.items.enumerated()), id: \.element.id) { index, item in
                             HomeSectionItemCard(item: item, rank: index + 1) {
@@ -103,12 +103,12 @@ struct HomeView: View {
                             }
                         }
                     } else {
-                        ForEach(Array(section.items.enumerated()), id: \.element.id) { index, item in
+                        ForEach(section.items) { item in
                             HomeSectionItemCard(item: item) {
-                                self.playItem(item, in: section, at: index)
+                                self.playItem(item, in: section, at: 0)
                             }
                             .contextMenu {
-                                self.contextMenuItems(for: item, in: section, at: index)
+                                self.contextMenuItems(for: item, in: section, at: 0)
                             }
                         }
                     }

Views/macOS/PlayerBar.swift

@@ -22,6 +22,12 @@ struct PlayerBar: View {
     @State private var volumeValue: Double = 1.0
     @State private var isAdjustingVolume = false
 
+    /// Cached formatted progress string to avoid repeated formatting.
+    @State private var formattedProgress: String = "0:00"
+    @State private var formattedRemaining: String = "-0:00"
+    /// Last integer second of progress to reduce string formatting frequency.
+    @State private var lastProgressSecond: Int = -1
+
     var body: some View {
         GlassEffectContainer(spacing: 0) {
             HStack(spacing: 0) {
@@ -102,6 +108,13 @@ struct PlayerBar: View {
             if !self.isSeeking, self.playerService.duration > 0 {
                 self.seekValue = newValue / self.playerService.duration
             }
+            // Only update formatted strings when the second changes to reduce Text view updates
+            let currentSecond = Int(newValue)
+            if currentSecond != self.lastProgressSecond {
+                self.lastProgressSecond = currentSecond
+                self.formattedProgress = self.formatTime(newValue)
+                self.formattedRemaining = "-\(self.formatTime(self.playerService.duration - newValue))"
+            }
         }
         .onChange(of: self.playerService.volume) { _, newValue in
             // Sync local volume value when not actively adjusting
@@ -175,11 +188,12 @@ struct PlayerBar: View {
 
     private var seekBarView: some View {
         HStack(spacing: 10) {
-            // Elapsed time - show seek position while dragging, actual progress otherwise
-            Text(self.formatTime(self.isSeeking ? self.seekValue * self.playerService.duration : self.playerService.progress))
+            // Elapsed time - use cached formatted string when not seeking
+            Text(self.isSeeking ? self.formatTime(self.seekValue * self.playerService.duration) : self.formattedProgress)
                 .font(.system(size: 11))
                 .foregroundStyle(.secondary)
                 .frame(minWidth: 45, alignment: .trailing)
+                .monospacedDigit()
 
             // Seek slider
             Slider(value: self.$seekValue, in: 0 ... 1) { editing in
@@ -193,11 +207,12 @@ struct PlayerBar: View {
             }
             .controlSize(.small)
 
-            // Remaining time
-            Text("-\(self.formatTime(self.playerService.duration - (self.isSeeking ? self.seekValue * self.playerService.duration : self.playerService.progress)))")
+            // Remaining time - use cached formatted string when not seeking
+            Text(self.isSeeking ? "-\(self.formatTime(self.playerService.duration - self.seekValue * self.playerService.duration))" : self.formattedRemaining)
                 .font(.system(size: 11))
                 .foregroundStyle(.secondary)
                 .frame(minWidth: 45, alignment: .leading)
+                .monospacedDigit()
         }
     }
 

Views/macOS/SearchView.swift

@@ -280,8 +280,8 @@ struct SearchView: View {
     private var resultsView: some View {
         ScrollView {
             LazyVStack(spacing: 0) {
-                ForEach(Array(self.viewModel.filteredItems.enumerated()), id: \.element.id) { index, item in
-                    self.resultRow(item, index: index)
+                ForEach(self.viewModel.filteredItems) { item in
+                    self.resultRow(item)
                     Divider()
                         .padding(.leading, 72)
                 }
@@ -327,7 +327,7 @@ struct SearchView: View {
         }
     }
 
-    private func resultRow(_ item: SearchResultItem, index: Int) -> some View {
+    private func resultRow(_ item: SearchResultItem) -> some View {
         Button {
             self.handleItemTap(item)
         } label: {
@@ -386,7 +386,6 @@ struct SearchView: View {
             .contentShape(Rectangle())
         }
         .buttonStyle(.interactiveRow(cornerRadius: 6))
-        .staggeredAppearance(index: min(index, 10))
         .contextMenu {
             self.contextMenuItems(for: item)
         }