fix comparison of integers of different signs: 'int' and 'size_type' (issue #103)

Author: kbrameld

ros_trick/ros_src/trick_ros2_control/include/trick_ros2_control/utils.hpp

@@ -44,7 +44,7 @@ std::vector<double> trick_response_convert(std::string& response)
   {
     return result;
   }
-  for (int i = 1; i < responseSplit.size(); i++)
+  for (size_t i = 1; i < responseSplit.size(); i++)
   {
     result.push_back(trick_string_convert(responseSplit[i]));
   }

ros_trick/ros_src/trick_ros2_control/src/socket.cpp

@@ -81,8 +81,8 @@ std::string Socket::receive()
   }
 
   std::string string_buffer = std::string(carry_on_buffer_) + std::string(buffer);
-  int last_newline_idx = string_buffer.rfind(trick_delimiter_, string_buffer.size() - 1);
-  int second_last_newline_idx = string_buffer.rfind(trick_delimiter_, string_buffer.size() - 2);
+  auto last_newline_idx = string_buffer.rfind(trick_delimiter_, string_buffer.size() - 1);
+  auto second_last_newline_idx = string_buffer.rfind(trick_delimiter_, string_buffer.size() - 2);
 
   // it means that we can clear carry on buffer
   if (last_newline_idx == string_buffer.size() - 1)

ros_trick/ros_src/trick_ros2_control/src/trick_system.cpp

@@ -240,7 +240,7 @@ hardware_interface::return_type TrickSystem::read(const rclcpp::Time& /*time*/,
                  trick_state_variables_.size(), raw_doubles_from_trick.size());
     return hardware_interface::return_type::OK;
   }
-  for (int i = 0; i < raw_doubles_from_trick.size(); ++i)
+  for (size_t i = 0; i < raw_doubles_from_trick.size(); ++i)
   {
     double value_from_trick = raw_doubles_from_trick[i];
     double* const target_state_variable_ptr_ = trick_state_variables_[i].data_ptr;