Skip to content

Restructure the contents of the docker repository #191

@franklinselva

Description

@franklinselva

Feature description

We are moving few contents of the docker repository to the demos repository as a part of space-ros/space-ros#178.

This will require the current structure to be updated to the new format and I am proposing new directory structure.

The soon to be stacks repository can be of the format as described below.

├── build.sh
├── Dockerfile.moveit2
├── Dockerfile.nav2
├── moveit2
│   ├── entrypoint.sh
│   ├── excluded-pkgs.txt
│   ├── moveit2-pkgs.txt
│   ├── moveit2_tutorials.repos
│   ├── octomap_fix.diff
│   ├── README.md
│   └── resources
├── navigation2
│   ├── entrypoint.sh
│   ├── navigation2.repos
│   └── README.md
├── README.md
├── renode_rcc
│   ├── build.sh
│   ├── config
│   ├── Dockerfile
│   ├── README.md
│   ├── renode-rtems-leon3
│   └── run.sh
├── rtems
│   ├── build.sh
│   ├── Dockerfile
│   ├── example
│   ├── hello
│   ├── hello_posix
│   ├── README.md
│   ├── run.sh
│   └── tinyxml2
├── run.sh
└── zynq_rtems
    ├── build_dependencies.sh
    ├── compile_demos.sh
    ├── Dockerfile
    ├── enter_container.sh
    ├── hello_network
    ├── hello_zenoh
    ├── README.md
    ├── start_network_tap.sh
    ├── stop_network_tap.sh
    └── toolchain.cmake

This could be a breaking change for some of the other issues but it should help will growing stacks for the project.

Implementation considerations

The key changes in the above proposal:

  • The space_robots directory related to the demos have been removed.
  • The build.sh and run.sh has been moved to root of the repository. This will allow stack images which doesn't need special process like the GUI variant as mentioned in Build docker variant for GUI apps #188. This change is subtle and likely can be skipped if necessary.
  • The build and run context of the stack images could be something like this,
# To build nav2 image for example,
docker build -t osrf/space-ros:nav2 -f Dockerfile.nav2 navigation2

This is not the complete proposed structure yet and might get updated soon before working on this.

Sub-issues

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions