Websocket high bandwith transfer: Client shutdown does not send a closing handshake as it shutdowns (SIGTERM), causing the server to error.

[VasilisThePikachu]

[DEBG] net: "[::1]:52071": Status changed to Disconnected, reason: "Client shutting down"
[INFO] net: "[::1]:52071": Disconnected ("Client shutting down")
[DEBG] net.transfer: Cleaning up connection for channel "1861180297712488418/1d427d70-7663-40ba-b9b0-473a39659e7f" that disconnected
[DEBG] srv: Last client disconnected, pausing automatically.
[DEBG] play_time: Saved 2 trackers for MyraTheAvali
[ERRO] net.transfer: Error reading transfer socket: System.Net.WebSockets.WebSocketException (0x80004005): The remote party closed the WebSocket connection without completing the close handshake.
   at System.Net.WebSockets.ManagedWebSocket.ThrowEOFUnexpected()
   at System.Net.WebSockets.ManagedWebSocket.EnsureBufferContainsAsync(Int32 minimumRequiredBytes, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.PoolingAsyncValueTaskMethodBuilder`1.StateMachineBox`1.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
   at System.Net.WebSockets.ManagedWebSocket.ReceiveAsyncPrivate[TResult](Memory`1 payloadBuffer, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.PoolingAsyncValueTaskMethodBuilder`1.StateMachineBox`1.System.Threading.Tasks.Sources.IValueTaskSource<TResult>.GetResult(Int16 token)
   at Robust.Shared.Network.Transfer.TransferImplWebSocket.ReadThread() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/Network/Transfer/TransferImplWebSocket.cs:line 55
[ERRO] net.transfer: Error reading transfer socket: System.Net.WebSockets.WebSocketException (0x80004005): The remote party closed the WebSocket connection without completing the close handshake.
   at System.Net.WebSockets.ManagedWebSocket.ThrowEOFUnexpected()
   at System.Net.WebSockets.ManagedWebSocket.EnsureBufferContainsAsync(Int32 minimumRequiredBytes, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.PoolingAsyncValueTaskMethodBuilder`1.StateMachineBox`1.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
   at System.Net.WebSockets.ManagedWebSocket.ReceiveAsyncPrivate[TResult](Memory`1 payloadBuffer, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.PoolingAsyncValueTaskMethodBuilder`1.StateMachineBox`1.System.Threading.Tasks.Sources.IValueTaskSource<TResult>.GetResult(Int16 token)
   at Robust.Shared.Network.Transfer.TransferImplWebSocket.ReadThread() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/Network/Transfer/TransferImplWebSocket.cs:line 55

1. Setup websockets
2. Connect to the server
3. Press alt + f4, or your operating systems close button.

[PJB3005]

Note that this will always be this error on the server in some capacity, as it can also be caused by networking errors/client crashes. That said, logging maybe should be nicer.

[VasilisThePikachu]

Note that this will always be this error on the server in some capacity, as it can also be caused by networking errors/client crashes. That said, logging maybe should be nicer.

Of course yes, although I do not believe alt + f4 or just pressing the x button on your browser should be properly closing the connection. Some proper shutdown is ran because the server receives the usual Client shutting down disconnect message. (AKA sigterm) (And not a timeout that would be expected from a sudden crash or missed packet.)

Pressing the "Quit" button on the server and then exiting from there does not cause this error to appear.