Clippy feedback

Author: spacejam

src/pagecache/iterator.rs

@@ -447,7 +447,7 @@ fn check_contiguity_in_unstable_tail(
     };
 
     // run the iterator to completion
-    while let Some(_) = iter.next() {}
+    for _ in &mut iter {}
 
     // `cur_lsn` is set to the beginning
     // of the next message

src/pagecache/snapshot.rs

@@ -264,7 +264,7 @@ fn advance_snapshot(
 
     let old_stable_lsn = snapshot.stable_lsn;
 
-    while let Some((log_kind, pid, lsn, ptr)) = iter.next() {
+    for (log_kind, pid, lsn, ptr) in &mut iter {
         trace!(
             "in advance_snapshot looking at item with pid {} lsn {} ptr {}",
             pid,

src/result.rs

@@ -49,7 +49,7 @@ pub enum Error {
 }
 
 impl Error {
-    pub(crate) fn corruption(at: Option<DiskPtr>) -> Error {
+    pub(crate) const fn corruption(at: Option<DiskPtr>) -> Error {
         Error::Corruption { at }
     }
 }

src/tree.rs

@@ -38,7 +38,7 @@ const fn out_of_bounds(numba: usize) -> bool {
 }
 
 #[cold]
-fn bounds_error() -> Result<()> {
+const fn bounds_error() -> Result<()> {
     Err(Error::Unsupported(
         "Keys and values are limited to \
         128gb on 64-bit platforms and