feat: generate random id for tests so they dont collide (#166)

TheOutdoorProgrammer · web-flow · commit 920c4fba2b73 · 2025-06-05T09:13:35.000-04:00
diff --git a/.spacelift/config.yml b/.spacelift/config.yml
@@ -4,50 +4,37 @@ module_version: 4.4.3
 tests:
   - name: AMD64-based workerpool
     project_root: examples/amd64
-    environment:
-      TF_VAR_worker_pool_id: "01HBD5QZ932J8EEH5GTBM1QMAA"
 
   - name: ARM64-based workerpool
     project_root: examples/arm64
-    environment:
-      TF_VAR_worker_pool_id: "01HBD5QZ932J8AEH5GTBM1QMAB"
 
   - name: extra-iam-statements
     project_root: examples/extra-iam-statements
-    environment:
-      TF_VAR_worker_pool_id: "01HBD5QZ932J8CEH5GTBM1QMAH"
 
   - name: Custom IAM Role
     project_root: examples/custom-iam-role
-    environment:
-      TF_VAR_worker_pool_id: "01HBD5QZ932J8CEH5GTBM1QMAC"
 
   - name: With autoscaling
     project_root: examples/autoscaler
     environment:
-      TF_VAR_worker_pool_id: "01HBD5QZ932J8CEH5GTBM1QMAD"
       TF_VAR_spacelift_api_key_id: "EXAMPLE0VOYU49U485BMZZVAWXU59VOW2"
       TF_VAR_spacelift_api_key_secret: "EXAMPLEf7anuofh4b6a4e43aplqt49099606de2mzbq4391tj1d3dc9872q23z8fvctu4kh"
       TF_VAR_spacelift_api_key_endpoint: "https://example.app.spacelift.io"
 
   - name: S3-hosted autoscaler
     project_root: examples/autoscaler-custom-s3-package
     environment:
-      TF_VAR_worker_pool_id: "01HBD5QZ932J8CEH5GTBM1QMAE"
       TF_VAR_spacelift_api_key_id: "EXAMPLE0VOYU49U485BMZZVAWXU59VOW2"
       TF_VAR_spacelift_api_key_secret: "EXAMPLEf7anuofh4b6a4e43aplqt49099606de2mzbq4391tj1d3dc9872q23z8fvctu4kh"
       TF_VAR_spacelift_api_key_endpoint: "https://example.app.spacelift.io"
       TF_VAR_autoscaler_version: "v1.0.3"
 
   - name: Self-hosted setup
     project_root: examples/self-hosted
-    environment:
-      TF_VAR_worker_pool_id: "01HBD5QZ932J8CEH5GTBM1QMAF"
 
   - name: With autoscaling, lifecycle rules and BYO ssm and secretsmanager
     project_root: examples/byo-ssm-secretsmanager-with-autoscaling-and-lifecycle
     environment:
-      TF_VAR_worker_pool_id: "01HBD5QZ932J8CEH5GTBM1QMAG"
       TF_VAR_spacelift_api_key_id: "EXAMPLE0VOYU49U485BMZZVAWXU59JOEY1"
       TF_VAR_spacelift_api_key_secret: "EXAMPLE22anuofh4b6a4e43aplqt49099606de2mzbq4391tj1d3dc9872q23z8fvctu4kh"
       TF_VAR_spacelift_api_key_endpoint: "https://example.app.spacelift.io"
diff --git a/examples/amd64/main.tf b/examples/amd64/main.tf
@@ -36,6 +36,17 @@ data "aws_subnets" "this" {
   }
 }
 
+resource "random_string" "worker_pool_id" {
+  length           = 26
+  numeric          = true
+  # Use special and override special to allow only uppercase letters and numbers
+  # but exclude I, L, O, and U as it does not conform to the regex used by Spacelift
+  special          = true
+  override_special = "ABCDEFGHJKMNPQRSTVWXYZ"
+  lower            = false
+  upper            = false
+}
+
 #### Spacelift worker pool ####
 
 module "this" {
@@ -51,25 +62,25 @@ module "this" {
   }
   security_groups = [data.aws_security_group.this.id]
   vpc_subnets     = data.aws_subnets.this.ids
-  worker_pool_id  = var.worker_pool_id
+  worker_pool_id  = random_string.worker_pool_id.id
 
   tag_specifications = [
     {
       resource_type = "instance"
       tags = {
-        Name = "sp5ft-${var.worker_pool_id}"
+        Name = "sp5ft-${random_string.worker_pool_id.id}"
       }
     },
     {
       resource_type = "volume"
       tags = {
-        Name = "sp5ft-${var.worker_pool_id}"
+        Name = "sp5ft-${random_string.worker_pool_id.id}"
       }
     },
     {
       resource_type = "network-interface"
       tags = {
-        Name = "sp5ft-${var.worker_pool_id}"
+        Name = "sp5ft-${random_string.worker_pool_id.id}"
       }
     }
   ]
diff --git a/examples/amd64/variables.tf b/examples/amd64/variables.tf
diff --git a/examples/arm64/main.tf b/examples/arm64/main.tf
@@ -36,6 +36,17 @@ data "aws_subnets" "this" {
   }
 }
 
+resource "random_string" "worker_pool_id" {
+  length           = 26
+  numeric          = true
+  # Use special and override special to allow only uppercase letters and numbers
+  # but exclude I, L, O, and U as it does not conform to the regex used by Spacelift
+  special          = true
+  override_special = "ABCDEFGHJKMNPQRSTVWXYZ"
+  lower            = false
+  upper            = false
+}
+
 #### Spacelift worker pool ####
 
 module "this" {
@@ -55,5 +66,5 @@ module "this" {
   ec2_instance_type = "t4g.micro"
   security_groups   = [data.aws_security_group.this.id]
   vpc_subnets       = data.aws_subnets.this.ids
-  worker_pool_id    = var.worker_pool_id
+  worker_pool_id    = random_string.worker_pool_id.id
 }
diff --git a/examples/arm64/variables.tf b/examples/arm64/variables.tf
diff --git a/examples/autoscaler-custom-s3-package/main.tf b/examples/autoscaler-custom-s3-package/main.tf
@@ -36,6 +36,17 @@ data "aws_subnets" "this" {
   }
 }
 
+resource "random_string" "worker_pool_id" {
+  length           = 26
+  numeric          = true
+  # Use special and override special to allow only uppercase letters and numbers
+  # but exclude I, L, O, and U as it does not conform to the regex used by Spacelift
+  special          = true
+  override_special = "ABCDEFGHJKMNPQRSTVWXYZ"
+  lower            = false
+  upper            = false
+}
+
 #### Spacelift worker pool ####
 
 module "this" {
@@ -47,7 +58,7 @@ module "this" {
   }
   security_groups = [data.aws_security_group.this.id]
   vpc_subnets     = data.aws_subnets.this.ids
-  worker_pool_id  = var.worker_pool_id
+  worker_pool_id  = random_string.worker_pool_id.id
 
   autoscaling_configuration = {
     version = var.autoscaler_version
diff --git a/examples/autoscaler-custom-s3-package/variables.tf b/examples/autoscaler-custom-s3-package/variables.tf
@@ -14,11 +14,6 @@ variable "spacelift_api_key_endpoint" {
   description = "Full URL of the Spacelift API endpoint to use, eg. https://demo.app.spacelift.io"
 }
 
-variable "worker_pool_id" {
-  type        = string
-  description = "ID (ULID) of the the worker pool."
-}
-
 variable "autoscaler_version" {
   description = "Version of the autoscaler to deploy"
   type        = string
diff --git a/examples/autoscaler/main.tf b/examples/autoscaler/main.tf
@@ -36,6 +36,17 @@ data "aws_subnets" "this" {
   }
 }
 
+resource "random_string" "worker_pool_id" {
+  length           = 26
+  numeric          = true
+  # Use special and override special to allow only uppercase letters and numbers
+  # but exclude I, L, O, and U as it does not conform to the regex used by Spacelift
+  special          = true
+  override_special = "ABCDEFGHJKMNPQRSTVWXYZ"
+  lower            = false
+  upper            = false
+}
+
 #### Spacelift worker pool ####
 
 module "this" {
@@ -47,7 +58,7 @@ module "this" {
   }
   security_groups = [data.aws_security_group.this.id]
   vpc_subnets     = data.aws_subnets.this.ids
-  worker_pool_id  = var.worker_pool_id
+  worker_pool_id  = random_string.worker_pool_id.id
 
   # Autoscaler VPC configuration
   autoscaling_vpc_sg_ids  = [data.aws_security_group.this.id]
diff --git a/examples/autoscaler/variables.tf b/examples/autoscaler/variables.tf
@@ -1,8 +1,3 @@
-variable "worker_pool_id" {
-  type        = string
-  description = "ID (ULID) of the the worker pool."
-}
-
 variable "spacelift_api_key_id" {
   type        = string
   description = "ID of the Spacelift API key to use"
diff --git a/examples/byo-ssm-secretsmanager-with-autoscaling-and-lifecycle/main.tf b/examples/byo-ssm-secretsmanager-with-autoscaling-and-lifecycle/main.tf
@@ -36,6 +36,17 @@ data "aws_subnets" "this" {
   }
 }
 
+resource "random_string" "worker_pool_id" {
+  length           = 26
+  numeric          = true
+  # Use special and override special to allow only uppercase letters and numbers
+  # but exclude I, L, O, and U as it does not conform to the regex used by Spacelift
+  special          = true
+  override_special = "ABCDEFGHJKMNPQRSTVWXYZ"
+  lower            = false
+  upper            = false
+}
+
 // This is just here for testing purposes.
 resource "random_pet" "byo" {
   prefix = "byo"
@@ -67,7 +78,7 @@ module "this" {
 
   security_groups = [data.aws_security_group.this.id]
   vpc_subnets     = data.aws_subnets.this.ids
-  worker_pool_id  = var.worker_pool_id
+  worker_pool_id  = random_string.worker_pool_id.id
 
   byo_secretsmanager = {
     name = aws_secretsmanager_secret.byo.name
diff --git a/examples/byo-ssm-secretsmanager-with-autoscaling-and-lifecycle/variables.tf b/examples/byo-ssm-secretsmanager-with-autoscaling-and-lifecycle/variables.tf
@@ -1,8 +1,3 @@
-variable "worker_pool_id" {
-  type        = string
-  description = "ID (ULID) of the the worker pool."
-}
-
 variable "spacelift_api_key_id" {
   type        = string
   description = "ID of the Spacelift API key to use"
diff --git a/examples/custom-iam-role/main.tf b/examples/custom-iam-role/main.tf
@@ -36,6 +36,17 @@ data "aws_subnets" "this" {
 
 data "aws_partition" "current" {}
 
+resource "random_string" "worker_pool_id" {
+  length           = 26
+  numeric          = true
+  # Use special and override special to allow only uppercase letters and numbers
+  # but exclude I, L, O, and U as it does not conform to the regex used by Spacelift
+  special          = true
+  override_special = "ABCDEFGHJKMNPQRSTVWXYZ"
+  lower            = false
+  upper            = false
+}
+
 resource "random_pet" "this" {}
 
 resource "aws_iam_role" "this" {
@@ -78,5 +89,5 @@ module "this" {
   custom_iam_role_name = aws_iam_role.this.name
   security_groups      = [data.aws_security_group.this.id]
   vpc_subnets          = data.aws_subnets.this.ids
-  worker_pool_id       = var.worker_pool_id
+  worker_pool_id       = random_string.worker_pool_id.id
 }
diff --git a/examples/custom-iam-role/variables.tf b/examples/custom-iam-role/variables.tf
diff --git a/examples/extra-iam-statements/main.tf b/examples/extra-iam-statements/main.tf
@@ -36,6 +36,17 @@ data "aws_subnets" "this" {
   }
 }
 
+resource "random_string" "worker_pool_id" {
+  length           = 26
+  numeric          = true
+  # Use special and override special to allow only uppercase letters and numbers
+  # but exclude I, L, O, and U as it does not conform to the regex used by Spacelift
+  special          = true
+  override_special = "ABCDEFGHJKMNPQRSTVWXYZ"
+  lower            = false
+  upper            = false
+}
+
 #### Spacelift worker pool ####
 
 module "this" {
@@ -51,7 +62,7 @@ module "this" {
   }
   security_groups = [data.aws_security_group.this.id]
   vpc_subnets     = data.aws_subnets.this.ids
-  worker_pool_id  = var.worker_pool_id
+  worker_pool_id  = random_string.worker_pool_id.id
   extra_iam_statements = [
     data.aws_iam_policy_document.extra.json,
   ]
diff --git a/examples/extra-iam-statements/variables.tf b/examples/extra-iam-statements/variables.tf
diff --git a/examples/self-hosted/main.tf b/examples/self-hosted/main.tf
@@ -36,6 +36,17 @@ data "aws_subnets" "this" {
   }
 }
 
+resource "random_string" "worker_pool_id" {
+  length           = 26
+  numeric          = true
+  # Use special and override special to allow only uppercase letters and numbers
+  # but exclude I, L, O, and U as it does not conform to the regex used by Spacelift
+  special          = true
+  override_special = "ABCDEFGHJKMNPQRSTVWXYZ"
+  lower            = false
+  upper            = false
+}
+
 #### Spacelift worker pool ####
 
 module "this" {
@@ -47,7 +58,7 @@ module "this" {
   }
   security_groups = [data.aws_security_group.this.id]
   vpc_subnets     = data.aws_subnets.this.ids
-  worker_pool_id  = var.worker_pool_id
+  worker_pool_id  = random_string.worker_pool_id.id
 
   selfhosted_configuration = {
     s3_uri                         = "s3://example-bucketname1234/spacelift-launcher"
diff --git a/examples/self-hosted/variables.tf b/examples/self-hosted/variables.tf

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,17 @@ data "aws_subnets" "this" {`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
	`39`	`+resource "random_string" "worker_pool_id" {`
	`40`	`+ length = 26`
	`41`	`+ numeric = true`
	`42`	`+ # Use special and override special to allow only uppercase letters and numbers`
	`43`	`+ # but exclude I, L, O, and U as it does not conform to the regex used by Spacelift`
	`44`	`+ special = true`
	`45`	`+ override_special = "ABCDEFGHJKMNPQRSTVWXYZ"`
	`46`	`+ lower = false`
	`47`	`+ upper = false`
	`48`	`+}`
	`49`	`+`
`39`	`50`	`#### Spacelift worker pool ####`
`40`	`51`
`41`	`52`	`module "this" {`
`@@ -51,25 +62,25 @@ module "this" {`
`51`	`62`	`}`
`52`	`63`	`security_groups = [data.aws_security_group.this.id]`
`53`	`64`	`vpc_subnets = data.aws_subnets.this.ids`
`54`		`- worker_pool_id = var.worker_pool_id`
	`65`	`+ worker_pool_id = random_string.worker_pool_id.id`
`55`	`66`
`56`	`67`	`tag_specifications = [`
`57`	`68`	`{`
`58`	`69`	`resource_type = "instance"`
`59`	`70`	`tags = {`
`60`		`- Name = "sp5ft-${var.worker_pool_id}"`
	`71`	`+ Name = "sp5ft-${random_string.worker_pool_id.id}"`
`61`	`72`	`}`
`62`	`73`	`},`
`63`	`74`	`{`
`64`	`75`	`resource_type = "volume"`
`65`	`76`	`tags = {`
`66`		`- Name = "sp5ft-${var.worker_pool_id}"`
	`77`	`+ Name = "sp5ft-${random_string.worker_pool_id.id}"`
`67`	`78`	`}`
`68`	`79`	`},`
`69`	`80`	`{`
`70`	`81`	`resource_type = "network-interface"`
`71`	`82`	`tags = {`
`72`		`- Name = "sp5ft-${var.worker_pool_id}"`
	`83`	`+ Name = "sp5ft-${random_string.worker_pool_id.id}"`
`73`	`84`	`}`
`74`	`85`	`}`
`75`	`86`	`]`