Skip to content

simplify by: depth + prefix.bit_len()== point #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

simplify by: depth + prefix.bit_len()== point #3

wants to merge 3 commits into from

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Apr 9, 2024 •
edited
Loading

The test shows bit_len() == point - depth is always true as long as point >= depth.

So depth + prefix.bit_len() is the same as depth + point - depth, which is depth.

(if point < depth, PathSegment::from_path will panic anyway.)

This PR also fixed the calculation of max_bit_len.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhiqiangxu