Make few protocol clean ups

Author: buffrr

protocol/src/constants.rs

@@ -16,6 +16,8 @@ pub struct ChainAnchor {
     pub height: u32,
 }
 
+pub const SPACES_SIGNED_MSG_PREFIX: &[u8] = b"\x17Spaces Signed Message:\n";
+
 pub const RESERVED_SPACES: [&'static [u8]; 3] = [b"\x07example", b"\x04test", b"\x05local"];
 
 /// The number of blocks between each rollout of new spaces for auction.
@@ -100,7 +102,8 @@ impl ChainAnchor {
 
 #[cfg(feature = "bincode")]
 pub mod bincode_impl {
-    use alloc::vec::Vec;
+    use crate::alloc::borrow::ToOwned;
+use alloc::vec::Vec;
 
     use bincode::{
         config,

protocol/src/hasher.rs

@@ -57,10 +57,15 @@ impl From<Hash> for SpaceKey {
 impl SpaceKey {
     #[inline(always)]
     pub fn from_raw(value: Hash) -> crate::errors::Result<Self> {
-        if (value[0] & 0b1000_0000) == 0 && (value[31] & 0b0000_0001) == 0 {
+        if Self::is_valid(&value) {
             return Ok(Self { 0: value });
         }
-        return Err(crate::errors::Error::IO("bad space hash".to_string()));
+        Err(crate::errors::Error::IO("bad space hash".to_string()))
+    }
+
+    #[inline(always)]
+    pub fn is_valid(value: &Hash) -> bool {
+        value[0] & 0b1000_0000 == 0 && value[31] & 0b0000_0001 == 0
     }
 
     pub fn from_slice_unchecked(slice: &[u8]) -> Self {
@@ -113,6 +118,11 @@ impl OutpointKey {
         let h = H::hash(&buffer);
         h.into()
     }
+
+    #[inline(always)]
+    pub fn is_valid(value: &Hash) -> bool {
+        value[0] & 0b1000_0000 == 0 && value[31] & 0b0000_0001 == 0b0000_0001
+    }
 }
 
 impl BidKey {

protocol/src/lib.rs

@@ -9,6 +9,10 @@ use alloc::{vec, vec::Vec};
 
 #[cfg(feature = "bincode")]
 use bincode::{Decode, Encode};
+
+#[cfg(feature = "serde")]
+use serde::{Deserialize, Serialize};
+
 use bitcoin::{
     psbt,
     secp256k1::{schnorr, Message},
@@ -17,8 +21,6 @@ use bitcoin::{
     transaction::Version,
     Amount, OutPoint, ScriptBuf, Transaction, TxIn, TxOut, Txid, Witness,
 };
-#[cfg(feature = "serde")]
-use serde::{Deserialize, Serialize};
 
 use crate::{
     constants::{BID_PSBT_INPUT_SEQUENCE, BID_PSBT_TX_LOCK_TIME, BID_PSBT_TX_VERSION},
@@ -33,6 +35,7 @@ pub mod script;
 pub mod slabel;
 pub mod validate;
 
+
 #[derive(Clone, PartialEq, Debug)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[cfg_attr(feature = "bincode", derive(Encode, Decode))]
@@ -214,6 +217,7 @@ pub mod serde_bytes_impl {
 
 #[cfg(feature = "bincode")]
 pub mod bincode_bytes_impl {
+    use alloc::vec::Vec;
     use bincode::{
         de::Decoder,
         enc::Encoder,

protocol/src/prepare.rs

@@ -1,4 +1,4 @@
-use alloc::vec::Vec;
+use alloc::{vec, vec::Vec};
 
 use bitcoin::{
     absolute::LockTime,