listtransactions

Author: Ximik

node/src/bin/space-cli.rs

@@ -207,6 +207,14 @@ enum Commands {
         #[arg(long, short)]
         fee_rate: Option<u64>,
     },
+    /// List last transactions
+    #[command(name = "listtransactions")]
+    ListTransactions {
+        #[arg(default_value = "1")]
+        count: usize,
+        #[arg(default_value = "0")]
+        skip: usize,
+    },
     /// List won spaces including ones
     /// still in auction with a winning bid
     #[command(name = "listspaces")]
@@ -574,6 +582,13 @@ async fn handle_commands(
             let spaces = cli.client.wallet_list_auction_outputs(&cli.wallet).await?;
             println!("{}", serde_json::to_string_pretty(&spaces)?);
         }
+        Commands::ListTransactions { count, skip } => {
+            let txs = cli
+                .client
+                .wallet_list_transactions(&cli.wallet, count, skip)
+                .await?;
+            println!("{}", serde_json::to_string_pretty(&txs)?);
+        }
         Commands::ListSpaces => {
             let spaces = cli.client.wallet_list_spaces(&cli.wallet).await?;
             println!("{}", serde_json::to_string_pretty(&spaces)?);

node/src/rpc.rs

@@ -44,7 +44,8 @@ use crate::{
     source::BitcoinRpc,
     store::{ChainState, LiveSnapshot},
     wallets::{
-        AddressKind, Balance, RpcWallet, TxResponse, WalletCommand, WalletOutput, WalletResponse,
+        AddressKind, Balance, RpcWallet, TxInfo, TxResponse, WalletCommand, WalletOutput,
+        WalletResponse,
     },
 };
 
@@ -163,6 +164,14 @@ pub trait Rpc {
         fee_rate: FeeRate,
     ) -> Result<Vec<TxResponse>, ErrorObjectOwned>;
 
+    #[method(name = "walletlisttransactions")]
+    async fn wallet_list_transactions(
+        &self,
+        wallet: &str,
+        count: usize,
+        skip: usize,
+    ) -> Result<Vec<TxInfo>, ErrorObjectOwned>;
+
     #[method(name = "walletlistspaces")]
     async fn wallet_list_spaces(&self, wallet: &str)
         -> Result<Vec<WalletOutput>, ErrorObjectOwned>;
@@ -715,6 +724,19 @@ impl RpcServer for RpcServerImpl {
             .map_err(|error| ErrorObjectOwned::owned(-1, error.to_string(), None::<String>))
     }
 
+    async fn wallet_list_transactions(
+        &self,
+        wallet: &str,
+        count: usize,
+        skip: usize,
+    ) -> Result<Vec<TxInfo>, ErrorObjectOwned> {
+        self.wallet(&wallet)
+            .await?
+            .send_list_transactions(count, skip)
+            .await
+            .map_err(|error| ErrorObjectOwned::owned(-1, error.to_string(), None::<String>))
+    }
+
     async fn wallet_list_spaces(
         &self,
         wallet: &str,

node/src/wallets.rs

@@ -20,13 +20,12 @@ use tokio::{
 };
 use wallet::{
     address::SpaceAddress,
-    bdk_wallet,
     bdk_wallet::{
+        self,
         chain::{local_chain::CheckPoint, BlockId},
         KeychainKind, LocalOutput,
     },
-    bitcoin,
-    bitcoin::{Address, Amount, FeeRate},
+    bitcoin::{self, Address, Amount, FeeRate},
     builder::{
         CoinTransfer, SpaceTransfer, SpacesAwareCoinSelection, TransactionTag, TransferRequest,
     },
@@ -51,6 +50,12 @@ pub struct TxResponse {
     pub error: Option<BTreeMap<String, String>>,
 }
 
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct TxInfo {
+    pub txid: Txid,
+    pub confirmed: bool,
+}
+
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct WalletResponse {
     pub sent: Vec<TxResponse>,
@@ -83,6 +88,11 @@ pub enum WalletCommand {
         fee_rate: FeeRate,
         resp: crate::rpc::Responder<anyhow::Result<Vec<TxResponse>>>,
     },
+    ListTransactions {
+        count: usize,
+        skip: usize,
+        resp: crate::rpc::Responder<anyhow::Result<Vec<TxInfo>>>,
+    },
     ListSpaces {
         resp: crate::rpc::Responder<anyhow::Result<Vec<WalletOutput>>>,
     },
@@ -154,8 +164,10 @@ impl RpcWallet {
             balance,
             dust: unspent
                 .into_iter()
-                .filter(|output| output.is_spaceout ||
-                    output.output.txout.value <= SpacesAwareCoinSelection::DUST_THRESHOLD)
+                .filter(|output| {
+                    output.is_spaceout
+                        || output.output.txout.value <= SpacesAwareCoinSelection::DUST_THRESHOLD
+                })
                 .map(|output| output.output.txout.value)
                 .sum(),
         };
@@ -224,6 +236,10 @@ impl RpcWallet {
             WalletCommand::ListUnspent { resp } => {
                 _ = resp.send(Self::list_unspent(wallet, state));
             }
+            WalletCommand::ListTransactions { count, skip, resp } => {
+                let transactions = Self::list_transactions(wallet, count, skip);
+                _ = resp.send(transactions);
+            }
             WalletCommand::ListSpaces { resp } => {
                 let result = Self::list_unspent(wallet, state);
                 match result {
@@ -375,6 +391,26 @@ impl RpcWallet {
         Ok(SpacesAwareCoinSelection::new(excluded))
     }
 
+    fn list_transactions(
+        wallet: &mut SpacesWallet,
+        count: usize,
+        skip: usize,
+    ) -> anyhow::Result<Vec<TxInfo>> {
+        let transactions = wallet
+            .spaces
+            .transactions()
+            .into_iter()
+            .skip(skip)
+            .take(count)
+            .map(|tx| {
+                let txid = tx.tx_node.txid.clone();
+                let confirmed = tx.chain_position.is_confirmed();
+                TxInfo { txid, confirmed }
+            })
+            .collect();
+        Ok(transactions)
+    }
+
     fn list_unspent(
         wallet: &mut SpacesWallet,
         store: &mut LiveSnapshot,
@@ -446,8 +482,10 @@ impl RpcWallet {
             if dust > SpacesAwareCoinSelection::DUST_THRESHOLD {
                 // Allowing higher dust may space outs to be accidentally
                 // spent during coin selection
-                return Err(anyhow!("dust cannot be higher than {}",
-                    SpacesAwareCoinSelection::DUST_THRESHOLD));
+                return Err(anyhow!(
+                    "dust cannot be higher than {}",
+                    SpacesAwareCoinSelection::DUST_THRESHOLD
+                ));
             }
         }
 
@@ -789,6 +827,18 @@ impl RpcWallet {
         resp_rx.await?
     }
 
+    pub async fn send_list_transactions(
+        &self,
+        count: usize,
+        skip: usize,
+    ) -> anyhow::Result<Vec<TxInfo>> {
+        let (resp, resp_rx) = oneshot::channel();
+        self.sender
+            .send(WalletCommand::ListTransactions { count, skip, resp })
+            .await?;
+        resp_rx.await?
+    }
+
     pub async fn send_list_spaces(&self) -> anyhow::Result<Vec<WalletOutput>> {
         let (resp, resp_rx) = oneshot::channel();
         self.sender.send(WalletCommand::ListSpaces { resp }).await?;

wallet/src/lib.rs

@@ -153,7 +153,7 @@ impl SpacesWallet {
     }
 
     pub fn get_info(&self) -> WalletInfo {
-        let mut descriptors = Vec::with_capacity(4);
+        let mut descriptors = Vec::with_capacity(2);
 
         descriptors.push(DescriptorInfo {
             descriptor: self