Skip to content

Commit e34e0bc

Browse files
Updating docstring for a test and removing a test that will unlikely be used in the future.
1 parent 21e9f17 commit e34e0bc

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

jwst/regtest/test_infrastructure.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -85,18 +85,6 @@ def test_diff_astropy_tables_columns(diff_astropy_tables, two_tables):
8585
assert diff_astropy_tables(path1, path2)
8686

8787

88-
@pytest.mark.xfail(reason="table meta comparison currently deactivated")
89-
def test_diff_astropy_tables_meta(diff_astropy_tables, two_tables):
90-
path1, path2 = two_tables
91-
92-
t1 = Table.read(path1)
93-
t1.meta = {"name": "not the first table"}
94-
t1.write(path1, overwrite=True, format="ascii.ecsv")
95-
96-
with pytest.raises(AssertionError, match="Metadata does not match"):
97-
assert diff_astropy_tables(path1, path2)
98-
99-
10088
def test_diff_astropy_tables_allclose(diff_astropy_tables, two_tables):
10189
path1, path2 = two_tables
10290

jwst/tests/test_helpers.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@ def test_warning_inside_capture_logging():
1717

1818
def test_unexpected_warning_inside_capture_logging():
1919
"""
20-
This should fail (see xfail) since the warning doesn't match.
21-
We're using an xfail here because we're testing that pytest.warns
22-
fails to catch a warnings.
20+
This test catches the exception raised due to warnings not matching.
21+
We're testing that pytest.warns fails to catch a warnings.
2322
"""
24-
with pytest.raises(UserWarning):
23+
with pytest.raises(UserWarning, match="not the warning"):
2524
with _help_pytest_warns(), pytest.warns(UserWarning, match="expected"):
2625
warnings.warn("not the warning you're looking for", UserWarning)
2726

0 commit comments

Comments
 (0)