Skip to content

Commit f154de5

Browse files
Use set_dependpent_cmake_args to configure FindMPI
1 parent a3ddb48 commit f154de5

File tree

34 files changed

+26
-116
lines changed

34 files changed

+26
-116
lines changed

repos/spack_repo/builtin/packages/adiak/package.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ class Adiak(CMakePackage):
3939
def cmake_args(self):
4040
args = []
4141
if self.spec.satisfies("+mpi"):
42-
args.append(f"-DMPI_CXX_COMPILER={self.spec['mpi'].mpicxx}")
43-
args.append(f"-DMPI_C_COMPILER={self.spec['mpi'].mpicc}")
4442
args.append("-DENABLE_MPI=ON")
4543
else:
4644
args.append("-DENABLE_MPI=OFF")

repos/spack_repo/builtin/packages/amr_wind/package.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,6 @@ def cmake_args(self):
152152

153153
if spec.satisfies("+mpi"):
154154
args.append(define("MPI_HOME", spec["mpi"].prefix))
155-
args.append(define("MPI_CXX_COMPILER", spec["mpi"].mpicxx))
156-
args.append(define("MPI_C_COMPILER", spec["mpi"].mpicc))
157155

158156
if spec.satisfies("+hdf5"):
159157
args.append(define("AMR_WIND_ENABLE_HDF5", True))

repos/spack_repo/builtin/packages/amrex/package.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -440,9 +440,6 @@ def test_run_install_test(self):
440440

441441
args = ["-S{0}".format(join_path(".", "cache", "amrex", "Tests", "SpackSmokeTest"))]
442442
args.append("-DAMReX_ROOT=" + self.prefix)
443-
if self.spec.satisfies("+mpi"):
444-
args.append("-DMPI_C_COMPILER=" + self.spec["mpi"].mpicc)
445-
args.append("-DMPI_CXX_COMPILER=" + self.spec["mpi"].mpicxx)
446443

447444
if self.spec.satisfies("+cuda"):
448445
args.append("-DCMAKE_CUDA_COMPILER=" + join_path(self.spec["cuda"].prefix.bin, "nvcc"))

repos/spack_repo/builtin/packages/ascent/package.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ class Ascent(CMakePackage, CudaPackage, ROCmPackage):
5757
url = "https://github.com/Alpine-DAV/ascent/releases/download/v0.5.1/ascent-v0.5.1-src-with-blt.tar.gz"
5858
tags = ["radiuss", "e4s"]
5959

60+
# Don't use the automatic hints in favor of building the hostconfig
61+
find_mpi_hints = False
62+
find_python_hints = False
63+
6064
maintainers("cyrush")
6165

6266
license("BSD-3-Clause")

repos/spack_repo/builtin/packages/axl/package.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,6 @@ def cmake_args(self):
8282
args.append(self.define("WITH_KVTREE_PREFIX", spec["kvtree"].prefix))
8383

8484
args.append(self.define_from_variant("MPI"))
85-
if spec.satisfies("+mpi"):
86-
args.append(self.define("MPI_C_COMPILER", spec["mpi"].mpicc))
8785

8886
if spec.satisfies("@:0.3.0"):
8987
apis = list(spec.variants["async_api"].value)

repos/spack_repo/builtin/packages/cardioid/package.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ def cmake_args(self):
4343
"-DENABLE_OPENMP:BOOL=ON",
4444
"-DENABLE_MPI:BOOL=ON",
4545
"-DENABLE_FIND_MPI:BOOL=OFF",
46-
"-DMPI_C_COMPILER:STRING=" + spec["mpi"].mpicc,
47-
"-DMPI_CXX_COMPILER:STRING=" + spec["mpi"].mpicxx,
4846
"-DCMAKE_C_COMPILER:STRING=" + spec["mpi"].mpicc,
4947
"-DCMAKE_CXX_COMPILER:STRING=" + spec["mpi"].mpicxx,
5048
]

repos/spack_repo/builtin/packages/chameleon/package.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -107,15 +107,6 @@ def cmake_args(self):
107107
]
108108
)
109109

110-
if spec.satisfies("+mpi ~simgrid"):
111-
args.extend(
112-
[
113-
self.define("MPI_C_COMPILER", self.spec["mpi"].mpicc),
114-
self.define("MPI_CXX_COMPILER", self.spec["mpi"].mpicxx),
115-
self.define("MPI_Fortran_COMPILER", self.spec["mpi"].mpifc),
116-
]
117-
)
118-
119110
if spec.satisfies("^[virtuals=blas,lapack] intel-oneapi-mkl threads=none"):
120111
args.extend([self.define("BLA_VENDOR", "Intel10_64lp_seq")])
121112
elif spec.satisfies("^[virtuals=blas,lapack] intel-oneapi-mkl"):

repos/spack_repo/builtin/packages/conduit/package.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ class Conduit(CMakePackage):
3939

4040
license("BSD-3-Clause")
4141

42+
# Don't use the automatic MPI hints in favor of building the hostconfig
43+
find_mpi_hints = False
44+
find_python_hints = False
45+
4246
version("develop", branch="develop", submodules=True)
4347
# note: the main branch in conduit was renamed to develop, this next entry
4448
# is to bridge any spack dependencies that are still using the name master

repos/spack_repo/builtin/packages/dealii/package.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -537,13 +537,6 @@ def cmake_args(self):
537537
# MPI
538538
options.append(self.define_from_variant("DEAL_II_WITH_MPI", "mpi"))
539539
if spec.satisfies("+mpi"):
540-
options.extend(
541-
[
542-
self.define("MPI_C_COMPILER", spec["mpi"].mpicc),
543-
self.define("MPI_CXX_COMPILER", spec["mpi"].mpicxx),
544-
self.define("MPI_Fortran_COMPILER", spec["mpi"].mpifc),
545-
]
546-
)
547540
# FIXME: Fix issues with undefined references in MPI. e.g,
548541
# libmpi.so: undefined reference to `opal_memchecker_base_isaddressable'
549542
if spec.satisfies("^openmpi"):

repos/spack_repo/builtin/packages/er/package.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ class Er(CMakePackage):
6060
def cmake_args(self):
6161
spec = self.spec
6262
args = []
63-
args.append(self.define("MPI_C_COMPILER", spec["mpi"].mpicc))
6463
args.append(self.define("WITH_KVTREE_PREFIX", spec["kvtree"].prefix))
6564
args.append(self.define("WITH_REDSET_PREFIX", spec["redset"].prefix))
6665
args.append(self.define("WITH_SHUFFILE_PREFIX", spec["shuffile"].prefix))

0 commit comments

Comments
 (0)