fix: review

Author: TheMj0ln1r

test/base-fork/Morpho.t.sol

@@ -200,6 +200,19 @@ contract MorphoDepositFailureTests is MorphoBaseTest {
         foreignController.depositERC4626(MORPHO_VAULT_USDS, 25_000_000e18, 25_000_000e18 + 1);
     }
 
+    function test_morpho_deposit_minSharesOutNotMetBoundary() external {
+        deal(Base.USDS, address(almProxy), 25_000_000e18);
+
+        uint256 overBoundaryShares = usdsVault.convertToShares(25_000_000e18 + 1);
+        uint256 atBoundaryShares   = usdsVault.convertToShares(25_000_000e18);
+
+        vm.startPrank(relayer);
+        vm.expectRevert("FC/min-shares-out-not-met");
+        foreignController.depositERC4626(MORPHO_VAULT_USDS, 25_000_000e18, overBoundaryShares);
+
+        foreignController.depositERC4626(MORPHO_VAULT_USDS, 25_000_000e18, atBoundaryShares);
+    }
+
 }
 
 contract MorphoDepositSuccessTests is MorphoBaseTest {
@@ -318,6 +331,24 @@ contract MorphoWithdrawFailureTests is MorphoBaseTest {
         vm.stopPrank();
     }
 
+    function test_morpho_withdraw_maxSharesInNotMetBoundary() external {
+        deal(Base.USDS, address(almProxy), 10_000_000e18);
+
+        uint256 underBoundaryShares = usdsVault.convertToShares(10_000_000e18) - 1;
+        uint256 atBoundaryShares    = usdsVault.convertToShares(10_000_000e18);
+        
+        vm.startPrank(relayer);
+
+        foreignController.depositERC4626(MORPHO_VAULT_USDS, 10_000_000e18, 0);
+
+        vm.expectRevert("FC/max-shares-in-not-met");
+        foreignController.withdrawERC4626(MORPHO_VAULT_USDS, 10_000_000e18, underBoundaryShares);
+
+        foreignController.withdrawERC4626(MORPHO_VAULT_USDS, 10_000_000e18, atBoundaryShares);
+        vm.stopPrank();
+    }
+
+
 }
 
 contract MorphoWithdrawSuccessTests is MorphoBaseTest {
@@ -497,6 +528,23 @@ contract MorphoRedeemFailureTests is MorphoBaseTest {
         vm.stopPrank();
     }
 
+    function test_morpho_redeem_minAssetsOutNotMetBoundary() external {
+        deal(Base.USDS, address(almProxy), 10_000_000e18);
+
+        uint256 overBoundaryAssets = usdsVault.convertToAssets(10_000_000e18) + 1;
+        uint256 atBoundaryAssets   = usdsVault.convertToAssets(10_000_000e18);
+        
+        vm.startPrank(relayer);
+
+        foreignController.depositERC4626(MORPHO_VAULT_USDS, 10_000_000e18, 10_000_000e18);
+
+        vm.expectRevert("FC/min-assets-out-not-met");
+        foreignController.redeemERC4626(MORPHO_VAULT_USDS, 10_000_000e18, overBoundaryAssets);
+
+        foreignController.redeemERC4626(MORPHO_VAULT_USDS, 10_000_000e18, atBoundaryAssets);
+        vm.stopPrank();
+    }
+
 }
 
 contract MorphoRedeemSuccessTests is MorphoBaseTest {

test/mainnet-fork/4626Calls.t.sol

@@ -135,6 +135,21 @@ contract MainnetControllerDepositERC4626FailureTests is SUSDSTestBase {
         mainnetController.depositERC4626(address(susds), 1e18, 1e18);
     }
 
+    function test_depositERC4626_minSharesOutNotMetBoundary() external {
+        uint256 overBoundaryShares = susds.convertToShares(5_000_000e18 + 1);
+        uint256 atBoundaryShares   = susds.convertToShares(5_000_000e18);
+
+        vm.startPrank(relayer);
+
+        mainnetController.mintUSDS(5_000_000e18);
+
+        vm.expectRevert("MC/min-shares-out-not-met");
+        mainnetController.depositERC4626(address(susds), 5_000_000e18, overBoundaryShares);
+
+        mainnetController.depositERC4626(address(susds), 5_000_000e18, atBoundaryShares);
+        vm.stopPrank();
+    }
+
 }
 
 contract MainnetControllerDepositERC4626Tests is SUSDSTestBase {
@@ -232,6 +247,24 @@ contract MainnetControllerWithdrawERC4626FailureTests is SUSDSTestBase {
         vm.stopPrank();
     }
 
+    function test_withdrawERC4626_maxSharesInNotMetBoundary() external {
+        // Because of rounding 1_000_000e18 is under boundary, 1_000_000e18 + 1 is at boundary
+
+        uint256 underBoundaryShares = susds.convertToShares(1_000_000e18);
+        uint256 atBoundaryShares    = susds.convertToShares(1_000_000e18 + 1);
+
+        vm.startPrank(relayer);
+
+        mainnetController.mintUSDS(2_000_000e18);
+        mainnetController.depositERC4626(address(susds), 2_000_000e18, 0);
+
+        vm.expectRevert("MC/max-shares-in-not-met");
+        mainnetController.withdrawERC4626(address(susds), 1_000_000e18, underBoundaryShares);
+
+        mainnetController.withdrawERC4626(address(susds), 1_000_000e18, atBoundaryShares);
+        vm.stopPrank();
+    }
+
 }
 
 contract MainnetControllerWithdrawERC4626Tests is SUSDSTestBase {
@@ -370,6 +403,24 @@ contract MainnetControllerRedeemERC4626FailureTests is SUSDSTestBase {
         vm.stopPrank();
     }
 
+    function test_redeemERC4626_minAssetsOutNotMetBoundary() external {
+        vm.startPrank(relayer);
+
+        mainnetController.mintUSDS(2_000_000e18);
+        mainnetController.depositERC4626(address(susds), 2_000_000e18, 0);
+
+        uint256 shares = susds.convertToShares(2_000_000e18);
+
+        uint256 overBoundaryAssets = susds.convertToAssets(shares) + 1;
+        uint256 atBoundaryAssets   = susds.convertToAssets(shares);
+
+        vm.expectRevert("MC/min-assets-out-not-met");
+        mainnetController.redeemERC4626(address(susds), shares, overBoundaryAssets);
+
+        mainnetController.redeemERC4626(address(susds), shares, atBoundaryAssets);
+        vm.stopPrank();
+    }
+
 }
 
 contract MainnetControllerRedeemERC4626Tests is SUSDSTestBase {

test/mainnet-fork/Maple.t.sol

@@ -156,6 +156,19 @@ contract MainnetControllerDepositERC4626MapleFailureTests is MapleTestBase {
         mainnetController.depositERC4626(address(syrup), 1_000_000e6, 0);
     }
 
+    function test_depositERC4626_maple_minSharesOutNotMetBoundary() external {
+        deal(address(usdc), address(almProxy), 1_000_000e6);
+
+        uint256 overBoundaryShares = syrup.convertToShares(1_000_000e6 + 1);
+        uint256 atBoundaryShares   = syrup.convertToShares(1_000_000e6);
+
+        vm.startPrank(relayer);
+        vm.expectRevert("MC/min-shares-out-not-met");
+        mainnetController.depositERC4626(address(syrup), 1_000_000e6, overBoundaryShares);
+
+        mainnetController.depositERC4626(address(syrup), 1_000_000e6, atBoundaryShares);
+    }
+
 }
 
 contract MainnetControllerDepositERC4626Tests is MapleTestBase {