Fix bound checks in analogWriteFrequency

Wenn0101 · Wenn0101 · commit f9b92239a712 · 2021-05-04T11:30:37.000-06:00
diff --git a/cores/arduino/sdk/core-implement/CommonAnalog.cpp b/cores/arduino/sdk/core-implement/CommonAnalog.cpp
@@ -213,10 +213,11 @@ ap3_err_t analogWriteFrameWidth(uint32_t width){
 
 ap3_err_t analogWriteFrequency(float freq){    
     uint32_t new_width = (uint32_t)(AP3_ANALOG_CLK_FREQ / freq);
+
     if (new_width > AP3_MAX_ANALOG_WRITE_WIDTH){
         return AP3_ERR;
     }
-    if (new_width < AP3_MAX_ANALOG_WRITE_WIDTH){
+    if (new_width < AP3_MIN_ANALOG_WRITE_WIDTH){
         return AP3_ERR;
     }
     _analogWriteWidth = new_width;

Original file line number	Diff line number	Diff line change
`@@ -213,10 +213,11 @@ ap3_err_t analogWriteFrameWidth(uint32_t width){`
`213`	`213`
`214`	`214`	`ap3_err_t analogWriteFrequency(float freq){`
`215`	`215`	`uint32_t new_width = (uint32_t)(AP3_ANALOG_CLK_FREQ / freq);`
	`216`	`+`
`216`	`217`	`if (new_width > AP3_MAX_ANALOG_WRITE_WIDTH){`
`217`	`218`	`return AP3_ERR;`
`218`	`219`	`}`
`219`		`- if (new_width < AP3_MAX_ANALOG_WRITE_WIDTH){`
	`220`	`+ if (new_width < AP3_MIN_ANALOG_WRITE_WIDTH){`
`220`	`221`	`return AP3_ERR;`
`221`	`222`	`}`
`222`	`223`	`_analogWriteWidth = new_width;`