Skip to content

Commit 2d38aea

Browse files
committed
Update FPS_GT511C3.cpp
Updated logic of Response_Packet::ErrorCodes::Errors_Enum Response_Packet::ErrorCodes::ParseFromBytes(byte high, byte low) to set error code for any non-zero high byte. Also updated comment in Verify1_1 to indicate default return value is set before error codes are checked.
1 parent 0c8c024 commit 2d38aea

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

FPS_GT511C3.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,10 @@ Response_Packet::ErrorCodes::Errors_Enum Response_Packet::ErrorCodes::ParseFromB
121121
if (high == 0x00)
122122
{
123123
}
124-
if (high == 0x01)
125-
{
124+
// grw 01/03/15 - replaced if clause with else clause for any non-zero high byte
125+
// if (high == 0x01)
126+
// {
127+
else {
126128
switch(low)
127129
{
128130
case 0x00: e = NO_ERROR; break;
@@ -555,7 +557,7 @@ int FPS_GT511C3::Verify1_1(int id)
555557
int retval = 0;
556558
if (rp->ACK == false)
557559
{
558-
retval = 3; // set default value of not verified
560+
retval = 3; // grw 01/03/15 - set default value of not verified before assignment
559561
if (rp->Error == Response_Packet::ErrorCodes::NACK_INVALID_POS) retval = 1;
560562
if (rp->Error == Response_Packet::ErrorCodes::NACK_IS_NOT_USED) retval = 2;
561563
if (rp->Error == Response_Packet::ErrorCodes::NACK_VERIFY_FAILED) retval = 3;

0 commit comments

Comments
 (0)