Delete settings.enableSD - see issue #104

enableSD is redundant. If the microSD card is present, it needs to be powered up. Otherwise it will pull the SPI lines low, preventing the IMU from starting.

Author: PaulZC

Firmware/OpenLog_Artemis/OpenLog_Artemis.ino

@@ -645,58 +645,55 @@ void loop() {
       Serial1.print(outputData); //Print to TX pin
 
     //Record to SD
-    if (settings.logData == true)
+    if ((settings.logData == true) && (online.microSD))
     {
-      if (settings.enableSD && online.microSD)
+      digitalWrite(PIN_STAT_LED, HIGH);
+      uint32_t recordLength = sensorDataFile.write(outputData, strlen(outputData));
+      if (recordLength != strlen(outputData)) //Record the buffer to the card
       {
-        digitalWrite(PIN_STAT_LED, HIGH);
-        uint32_t recordLength = sensorDataFile.write(outputData, strlen(outputData));
-        if (recordLength != strlen(outputData)) //Record the buffer to the card
+        if (settings.printDebugMessages == true)
         {
-          if (settings.printDebugMessages == true)
-          {
-            SerialPrintf3("*** sensorDataFile.write data length mismatch! *** recordLength: %d, outputDataLength: %d\r\n", recordLength, strlen(outputData));
-          }
+          SerialPrintf3("*** sensorDataFile.write data length mismatch! *** recordLength: %d, outputDataLength: %d\r\n", recordLength, strlen(outputData));
         }
+      }
+
+      //Force sync every 500ms
+      if (bestMillis() - lastDataLogSyncTime > 500)
+      {
+        lastDataLogSyncTime = bestMillis();
+        sensorDataFile.sync();
+        if (settings.frequentFileAccessTimestamps == true)
+          updateDataFileAccess(&sensorDataFile); // Update the file access time & date
+      }
 
-        //Force sync every 500ms
-        if (bestMillis() - lastDataLogSyncTime > 500)
+      //Check if it is time to open a new log file
+      uint64_t secsSinceLastFileNameChange = rtcMillis() - lastSDFileNameChangeTime; // Calculate how long we have been logging for
+      secsSinceLastFileNameChange /= 1000ULL; // Convert to secs
+      if ((settings.openNewLogFilesAfter > 0) && (((unsigned long)secsSinceLastFileNameChange) >= settings.openNewLogFilesAfter))
+      {
+        //Close existings files
+        if (online.dataLogging == true)
         {
-          lastDataLogSyncTime = bestMillis();
           sensorDataFile.sync();
-          if (settings.frequentFileAccessTimestamps == true)
-            updateDataFileAccess(&sensorDataFile); // Update the file access time & date
+          updateDataFileAccess(&sensorDataFile); // Update the file access time & date
+          sensorDataFile.close();
+          strcpy(sensorDataFileName, findNextAvailableLog(settings.nextDataLogNumber, "dataLog"));
+          beginDataLogging(); //180ms
+          if (settings.showHelperText == true) printHelperText(false); //printHelperText to terminal and sensor file
         }
-
-        //Check if it is time to open a new log file
-        uint64_t secsSinceLastFileNameChange = rtcMillis() - lastSDFileNameChangeTime; // Calculate how long we have been logging for
-        secsSinceLastFileNameChange /= 1000ULL; // Convert to secs
-        if ((settings.openNewLogFilesAfter > 0) && (((unsigned long)secsSinceLastFileNameChange) >= settings.openNewLogFilesAfter))
+        if (online.serialLogging == true)
         {
-          //Close existings files
-          if (online.dataLogging == true)
-          {
-            sensorDataFile.sync();
-            updateDataFileAccess(&sensorDataFile); // Update the file access time & date
-            sensorDataFile.close();
-            strcpy(sensorDataFileName, findNextAvailableLog(settings.nextDataLogNumber, "dataLog"));
-            beginDataLogging(); //180ms
-            if (settings.showHelperText == true) printHelperText(false); //printHelperText to terminal and sensor file
-          }
-          if (online.serialLogging == true)
-          {
-            serialDataFile.sync();
-            updateDataFileAccess(&serialDataFile); // Update the file access time & date
-            serialDataFile.close();
-            strcpy(serialDataFileName, findNextAvailableLog(settings.nextSerialLogNumber, "serialLog"));
-            beginSerialLogging();
-          }
-
-          lastSDFileNameChangeTime = rtcMillis(); // Record the time of the file name change
+          serialDataFile.sync();
+          updateDataFileAccess(&serialDataFile); // Update the file access time & date
+          serialDataFile.close();
+          strcpy(serialDataFileName, findNextAvailableLog(settings.nextSerialLogNumber, "serialLog"));
+          beginSerialLogging();
         }
 
-        digitalWrite(PIN_STAT_LED, LOW);
+        lastSDFileNameChangeTime = rtcMillis(); // Record the time of the file name change
       }
+
+      digitalWrite(PIN_STAT_LED, LOW);
     }
 
     if ((settings.useGPIO32ForStopLogging == true) && (stopLoggingSeen == true)) // Has the user pressed the stop logging button?
@@ -892,56 +889,51 @@ void beginSD()
   pin_config(PinName(PIN_MICROSD_CHIP_SELECT), g_AM_HAL_GPIO_OUTPUT); // Make sure the pin does actually get re-configured
   digitalWrite(PIN_MICROSD_CHIP_SELECT, HIGH); //Be sure SD is deselected
 
-  if (settings.enableSD == true)
-  {
-    // For reasons I don't understand, we seem to have to wait for at least 1ms after SPI.begin before we call microSDPowerOn.
-    // If you comment the next line, the Artemis resets at microSDPowerOn when beginSD is called from wakeFromSleep...
-    // But only on one of my V10 red boards. The second one I have doesn't seem to need the delay!?
-    delay(5);
+  // If the microSD card is present, it needs to be powered on otherwise the IMU will fail to start
+  // (The microSD card will pull the SPI pins low, preventing communication with the IMU)
+
+  // For reasons I don't understand, we seem to have to wait for at least 1ms after SPI.begin before we call microSDPowerOn.
+  // If you comment the next line, the Artemis resets at microSDPowerOn when beginSD is called from wakeFromSleep...
+  // But only on one of my V10 red boards. The second one I have doesn't seem to need the delay!?
+  delay(5);
 
-    microSDPowerOn();
+  microSDPowerOn();
 
-    //Max power up time is 250ms: https://www.kingston.com/datasheets/SDCIT-specsheet-64gb_en.pdf
-    //Max current is 200mA average across 1s, peak 300mA
-    for (int i = 0; i < 10; i++) //Wait
+  //Max power up time is 250ms: https://www.kingston.com/datasheets/SDCIT-specsheet-64gb_en.pdf
+  //Max current is 200mA average across 1s, peak 300mA
+  for (int i = 0; i < 10; i++) //Wait
+  {
+    checkBattery();
+    delay(1);
+  }
+
+  if (sd.begin(SD_CONFIG) == false) // Try to begin the SD card using the correct chip select
+  {
+    printDebug(F("SD init failed (first attempt). Trying again...\r\n"));
+    for (int i = 0; i < 250; i++) //Give SD more time to power up, then try again
     {
       checkBattery();
       delay(1);
     }
-
     if (sd.begin(SD_CONFIG) == false) // Try to begin the SD card using the correct chip select
     {
-      printDebug(F("SD init failed (first attempt). Trying again...\r\n"));
-      for (int i = 0; i < 250; i++) //Give SD more time to power up, then try again
-      {
-        checkBattery();
-        delay(1);
-      }
-      if (sd.begin(SD_CONFIG) == false) // Try to begin the SD card using the correct chip select
-      {
-        SerialPrintln(F("SD init failed (second attempt). Is card present? Formatted?"));
-        SerialPrintln(F("Please ensure the SD card is formatted correctly using https://www.sdcard.org/downloads/formatter/"));
-        digitalWrite(PIN_MICROSD_CHIP_SELECT, HIGH); //Be sure SD is deselected
-        online.microSD = false;
-        return;
-      }
-    }
-
-    //Change to root directory. All new file creation will be in root.
-    if (sd.chdir() == false)
-    {
-      SerialPrintln(F("SD change directory failed"));
+      SerialPrintln(F("SD init failed (second attempt). Is card present? Formatted?"));
+      SerialPrintln(F("Please ensure the SD card is formatted correctly using https://www.sdcard.org/downloads/formatter/"));
+      digitalWrite(PIN_MICROSD_CHIP_SELECT, HIGH); //Be sure SD is deselected
       online.microSD = false;
       return;
     }
-
-    online.microSD = true;
   }
-  else
+
+  //Change to root directory. All new file creation will be in root.
+  if (sd.chdir() == false)
   {
-    microSDPowerOff();
+    SerialPrintln(F("SD change directory failed"));
     online.microSD = false;
+    return;
   }
+
+  online.microSD = true;
 }
 
 void enableCIPOpullUp() // updated for v2.1.0 of the Apollo3 core

Firmware/OpenLog_Artemis/Sensors.ino

@@ -1541,7 +1541,7 @@ void printHelperText(bool terminalOnly)
   strcat(helperText, "\r\n");
 
   SerialPrint(helperText);
-  if ((terminalOnly == false) && (settings.logData == true) && (online.microSD) && (settings.enableSD && online.microSD))
+  if ((terminalOnly == false) && (settings.logData == true) && (online.microSD))
     sensorDataFile.print(helperText);
 }
 

Firmware/OpenLog_Artemis/menuMain.ino

@@ -25,7 +25,7 @@ void menuMain()
 
     SerialPrintln(F("h) Print Sensor Helper Text (and return to logging)"));
 
-    if (settings.enableSD && online.microSD)
+    if (online.microSD)
       SerialPrintln(F("s) SD Card File Transfer"));
 
     SerialPrintln(F("r) Reset all settings to default"));
@@ -61,7 +61,7 @@ void menuMain()
       menuDebug();
     else if (incoming == 's')
     {
-      if (settings.enableSD && online.microSD)
+      if (online.microSD)
       {
         //Close log files before showing sdCardMenu
         if (online.dataLogging == true)

Firmware/OpenLog_Artemis/nvm.ino

@@ -113,7 +113,6 @@ void recordSystemSettingsToFile()
     settingsFile.println("logMaxRate=" + (String)settings.logMaxRate);
     settingsFile.println("enableRTC=" + (String)settings.enableRTC);
     settingsFile.println("enableIMU=" + (String)settings.enableIMU);
-    settingsFile.println("enableSD=" + (String)settings.enableSD);
     settingsFile.println("enableTerminalOutput=" + (String)settings.enableTerminalOutput);
     settingsFile.println("logDate=" + (String)settings.logDate);
     settingsFile.println("logTime=" + (String)settings.logTime);
@@ -325,8 +324,6 @@ bool parseLine(char* str) {
     settings.enableRTC = d;
   else if (strcmp(settingName, "enableIMU") == 0)
     settings.enableIMU = d;
-  else if (strcmp(settingName, "enableSD") == 0)
-    settings.enableSD = d;
   else if (strcmp(settingName, "enableTerminalOutput") == 0)
     settings.enableTerminalOutput = d;
   else if (strcmp(settingName, "logDate") == 0)

Firmware/OpenLog_Artemis/settings.h

@@ -352,7 +352,6 @@ struct struct_settings {
   bool logMaxRate = false;
   bool enableRTC = true;
   bool enableIMU = true;
-  bool enableSD = true;
   bool enableTerminalOutput = true;
   bool logDate = true;
   bool logTime = true;