Skip to content

Commit 1af4798

Browse files
committed
Remove erroneous GNSS receiver update
updateGNSSSettings was being forced to true no matter what. Removing. In the future, we should set updateGNSSSettings to true any time a given setting cannot be changed instantaneously and thus requires the GNSS receiver be sent through all its configuration functions at the next boot. The most common example of this is when the user exits Web Config: a large number of settings may have been changed, and therefor the GNSS should be configured after reset.
1 parent ecd06fc commit 1af4798

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

Firmware/RTK_Everywhere/NVM.ino

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -977,7 +977,6 @@ bool parseLine(char *str)
977977
}
978978

979979
bool knownSetting = false;
980-
bool updateGNSS = false;
981980

982981
if (settings.debugSettings)
983982
systemPrintf("settingName: %s - value: %s - d: %0.9f\r\n", settingName, settingString, d);
@@ -1034,7 +1033,6 @@ bool parseLine(char *str)
10341033
{
10351034
qualifier = rtkSettingsEntries[i].qualifier;
10361035
type = rtkSettingsEntries[i].type;
1037-
updateGNSS |= rtkSettingsEntries[i].updateGNSSOnChange; // Does this setting require a GNSS update?
10381036
var = rtkSettingsEntries[i].var;
10391037
switch (type)
10401038
{
@@ -1538,9 +1536,6 @@ bool parseLine(char *str)
15381536
knownSetting = true;
15391537
}
15401538

1541-
if (updateGNSS)
1542-
settings.updateGNSSSettings = true;
1543-
15441539
// Last catch
15451540
if (knownSetting == false)
15461541
{

0 commit comments

Comments
 (0)