Prevent NtripServer from disabling settings.enableNtripServer

PaulZC · PaulZC · commit 2b5a3c78a5fa · 2024-06-13T14:43:32.000+01:00
diff --git a/Firmware/RTK_Everywhere/NtripServer.ino b/Firmware/RTK_Everywhere/NtripServer.ino
@@ -548,7 +548,11 @@ void ntripServerStop(int serverIndex, bool shutdown)
                 enabled = true;
                 break;
             }
-        settings.enableNtripServer = enabled;
+        //settings.enableNtripServer = enabled;
+        // ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Why? Setting settings.enableNtripServer to false means
+        // the server connections cannot be (re)started without setting settings.enableNtripServer back
+        // to true via the menu / web config... Was the intent to close the network connection when all
+        // servers have disconnected?
     }
     else
         ntripServerSetState(ntripServer, NTRIP_SERVER_ON);

Original file line number	Diff line number	Diff line change
`@@ -548,7 +548,11 @@ void ntripServerStop(int serverIndex, bool shutdown)`
`548`	`548`	`enabled = true;`
`549`	`549`	`break;`
`550`	`550`	`}`
`551`		`- settings.enableNtripServer = enabled;`
	`551`	`+ //settings.enableNtripServer = enabled;`
	`552`	`+ // ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Why? Setting settings.enableNtripServer to false means`
	`553`	`+ // the server connections cannot be (re)started without setting settings.enableNtripServer back`
	`554`	`+ // to true via the menu / web config... Was the intent to close the network connection when all`
	`555`	`+ // servers have disconnected?`
`552`	`556`	`}`
`553`	`557`	`else`
`554`	`558`	`ntripServerSetState(ntripServer, NTRIP_SERVER_ON);`