Better diagnostics:

make pointperfectPrintKeyInformation print who it was called by
periodic print subscribed topics in MQTT Client

Author: PaulZC

Firmware/RTK_Everywhere/Developer.ino

@@ -266,7 +266,7 @@ void updatePPL() {}
 bool sendGnssToPpl(uint8_t *buffer, int numDataBytes) {return false;}
 bool sendSpartnToPpl(uint8_t *buffer, int numDataBytes) {return false;}
 bool sendAuxSpartnToPpl(uint8_t *buffer, int numDataBytes) {return false;}
-void pointperfectPrintKeyInformation() {systemPrintln("**PPL Not Compiled**");}
+void pointperfectPrintKeyInformation(const char *requestedBy) {systemPrintln("**PPL Not Compiled**");}
 
 #endif  // COMPILE_POINTPERFECT_LIBRARY
 

Firmware/RTK_Everywhere/HTTP_Client.ino

@@ -540,7 +540,7 @@ void httpClientUpdate()
                     settings.pointPerfectNextKeyStart = (*jsonZtp)["dynamickeys"]["next"]["start"];
 
                     if (settings.debugCorrections || settings.debugHttpClientData)
-                        pointperfectPrintKeyInformation();
+                        pointperfectPrintKeyInformation("HTTP Client");
 
                     // displayKeysUpdated();
 

Firmware/RTK_Everywhere/MQTT_Client.ino

@@ -474,7 +474,7 @@ void mqttClientReceiveMessage(int messageSize)
                 recordSystemSettings(); // Record these settings to unit
 
                 if (settings.debugCorrections == true)
-                    pointperfectPrintKeyInformation();
+                    pointperfectPrintKeyInformation("MQTT Topic");
             }
 
             // Correction data from PP can go direct to GNSS
@@ -585,6 +585,23 @@ void mqttClientSetState(uint8_t newState)
         }
         else
             systemPrintln(mqttClientStateName[mqttClientState]);
+
+        systemPrint("MQTT Client subscribe topics: ");
+        for (auto it = mqttSubscribeTopics.begin(); it != mqttSubscribeTopics.end(); it = std::next(it))
+        {
+            String topic = *it;
+            systemPrint(topic);
+            systemPrint(" ");
+        }
+        systemPrintln();
+        systemPrint("MQTT Client subscribed topics: ");
+        for (auto it = mqttSubscribedTopics.begin(); it != mqttSubscribedTopics.end(); it = std::next(it))
+        {
+            String topic = *it;
+            systemPrint(topic);
+            systemPrint(" ");
+        }
+        systemPrintln();
     }
 }
 
@@ -859,8 +876,10 @@ void mqttClientUpdate()
         {
             mqttSubscribeTopics.push_back(MQTT_TOPIC_ASSISTNOW);
         }
+        
         // Subscribe to the key distribution topic
         mqttSubscribeTopics.push_back(String(settings.pointPerfectKeyDistributionTopic));
+        
         // Subscribe to the continental correction topic for our region - if we have one. L-Band-only does not.
         if (strlen(settings.regionalCorrectionTopics[settings.geographicRegion]) > 0)
         {

Firmware/RTK_Everywhere/PointPerfectLibrary.ino

@@ -364,7 +364,7 @@ bool getUsablePplKey(char *keyBuffer, int keyBufferSize)
 
     if (settings.debugCorrections == true)
     {
-        pointperfectPrintKeyInformation();
+        pointperfectPrintKeyInformation("getUsablePplKey");
         systemPrintf("Days remaining until current key expires: %d\r\n", daysRemainingCurrent);
         systemPrintf("Days remaining until next key expires: %d\r\n", daysRemainingNext);
     }
@@ -525,8 +525,10 @@ const char *PPLReturnStatusToStr(ePPL_ReturnStatus status)
     }
 }
 
-void pointperfectPrintKeyInformation()
+void pointperfectPrintKeyInformation(const char *requestedBy)
 {
+    // All calls to pointperfectPrintKeyInformation are guarded by settings.debugCorrections
+    systemPrintf("  pointPerfect keys print requested by %s\r\n", requestedBy);
     systemPrintf("  pointPerfectCurrentKey: %s\r\n", settings.pointPerfectCurrentKey);
     systemPrintf(
         "  pointPerfectCurrentKeyStart: %lld - %s\r\n", settings.pointPerfectCurrentKeyStart,

Firmware/RTK_Everywhere/menuPP.ino

@@ -128,7 +128,7 @@ void menuPointPerfectKeys()
             settings.pointPerfectNextKeyDuration = settings.pointPerfectCurrentKeyDuration;
 
             if (settings.debugCorrections == true)
-                pointperfectPrintKeyInformation();
+                pointperfectPrintKeyInformation("Menu PP");
         }
         else if (incoming == 4)
         {