Skip to content

Commit 4032cab

Browse files
committed
Initialize ppl flags to ensure PPL starts when provisioned, and
also call setRTCMPortMessage not setNMEAPortMessage. But I don't think this fixes anything. The code inside setRTCMPortMessage and setNMEAPortMessage appears identical... The real issue is #260...
1 parent 978aa3c commit 4032cab

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

Firmware/RTK_Everywhere/RTK_Everywhere.ino

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -629,14 +629,14 @@ const int updatePplTaskStackSize = 3000;
629629

630630
#endif // COMPILE_POINTPERFECT_LIBRARY
631631

632-
bool pplNewRtcmNmea;
633-
bool pplNewSpartn;
632+
bool pplNewRtcmNmea = false;
633+
bool pplNewSpartn = false;
634634
uint8_t *pplRtcmBuffer;
635635

636-
bool pplAttemptedStart;
637-
bool pplGnssOutput;
638-
bool pplMqttCorrections;
639-
long pplKeyExpirationMs; // Milliseconds until the current PPL key expires
636+
bool pplAttemptedStart = false;
637+
bool pplGnssOutput = false;
638+
bool pplMqttCorrections = false;
639+
unsigned long pplKeyExpirationMs = 0; // Milliseconds until the current PPL key expires
640640

641641
//=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
642642

Firmware/RTK_Everywhere/UM980.ino

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -393,13 +393,13 @@ bool um980EnableRTCMRover()
393393
{
394394
// Force on any messages that are needed for PPL
395395
if (rtcm1019Enabled == false)
396-
response &= um980->setNMEAPortMessage("RTCM1019", "COM3", 1);
396+
response &= um980->setRTCMPortMessage("RTCM1019", "COM3", 1);
397397
if (rtcm1020Enabled == false)
398-
response &= um980->setNMEAPortMessage("RTCM1020", "COM3", 1);
398+
response &= um980->setRTCMPortMessage("RTCM1020", "COM3", 1);
399399
if (rtcm1042Enabled == false)
400-
response &= um980->setNMEAPortMessage("RTCM1042", "COM3", 1);
400+
response &= um980->setRTCMPortMessage("RTCM1042", "COM3", 1);
401401
if (rtcm1046Enabled == false)
402-
response &= um980->setNMEAPortMessage("RTCM1046", "COM3", 1);
402+
response &= um980->setRTCMPortMessage("RTCM1046", "COM3", 1);
403403
}
404404

405405
return (response);

0 commit comments

Comments
 (0)