Add delay to CLI during LIST printing

Author: nseidle

Firmware/RTK_Everywhere/System.ino

@@ -411,6 +411,9 @@ void settingsToDefaults()
 // Periodically print information if enabled
 void printReports()
 {
+    if (bluetoothCommandIsConnected() == true)
+        return;
+
     // Periodically print the position
     if (settings.enablePrintPosition && ((millis() - lastPrintPosition) > 15000))
     {

Firmware/RTK_Everywhere/menuCommands.ino

@@ -496,8 +496,21 @@ void commandSendAllInterfaces(char *rxData)
 
     // Don't re-direct if we're doing a count of the print output
     if (printEndpoint != PRINT_ENDPOINT_COUNT)
+    {
         printEndpoint = PRINT_ENDPOINT_ALL;
 
+        // The LIST command dumps a large amount of data across the BLE link causing "esp_ble_gatts_send_ notify: rc=-1"
+        // errors
+
+        // With debug=debug, 788 characters are printed locally that slow down the interface enough to avoid errors,
+        // or 68.4ms at 115200 
+        // With debug=error, can we delay 70ms after every line print and avoid errors? Yes! Works
+        // well. 50ms is good, 25ms works sometimes without error, 5 is bad.
+
+        if (bluetoothCommandIsConnected())
+            delay(settings.cliBlePrintDelay_ms);
+    }
+
     systemPrint(rxData); // Send command output to BLE, SPP, and Serial
     printEndpoint = originalPrintEndpoint;
 }

Firmware/RTK_Everywhere/menuSystem.ino

@@ -519,6 +519,8 @@ void menuDebugHardware()
         systemPrint("19) Print CLI Debugging: ");
         systemPrintf("%s\r\n", settings.debugCLI ? "Enabled" : "Disabled");
 
+        systemPrintf("20) Delay between CLI LIST prints over BLE: %d\r\n", settings.cliBlePrintDelay_ms);
+
         systemPrintln("e) Erase LittleFS");
 
         systemPrintln("t) Test Screen");
@@ -590,7 +592,9 @@ void menuDebugHardware()
             else if (present.gnss_lg290p)
             {
                 systemPrintln();
-                systemPrintf("QGNSS must be connected to CH342 Port B at %dbps. Begin firmware update from QGNSS (hit the play button) then reset the LG290P.\r\n", settings.dataPortBaud);
+                systemPrintf("QGNSS must be connected to CH342 Port B at %dbps. Begin firmware update from QGNSS (hit "
+                             "the play button) then reset the LG290P.\r\n",
+                             settings.dataPortBaud);
                 gnssReset();
                 delay(100);
                 gnssBoot();
@@ -629,6 +633,15 @@ void menuDebugHardware()
         {
             settings.debugCLI ^= 1;
         }
+        else if (incoming == 20)
+        {
+            systemPrintf("Enter millisecond delay (%d to %d) for CLI LIST command over BLE: ", 0, 1000);
+            int newDelay = getUserInputNumber(); // Returns EXIT, TIMEOUT, or long
+            if ((newDelay != INPUT_RESPONSE_GETNUMBER_EXIT) && (newDelay != INPUT_RESPONSE_GETNUMBER_TIMEOUT))
+            {
+                settings.cliBlePrintDelay_ms = newDelay;
+            }
+        }
 
         else if (incoming == 'e')
         {

Firmware/RTK_Everywhere/settings.h

@@ -1103,6 +1103,7 @@ struct Settings
     bool enableNtripCaster = false; //When true, respond as a faux NTRIP Caster to incoming TCP connections
     bool baseCasterOverride = false; //When true, user has put device into 'BaseCast' mode. Change settings, but don't save to NVM.
     bool debugCLI = false; //When true, output BLE CLI interactions over serial
+    uint16_t cliBlePrintDelay_ms = 50; // Time delayed between prints during a LIST command to avoid overwhelming the BLE connection
 
     // Add new settings to appropriate group above or create new group
     // Then also add to the same group in rtkSettingsEntries below
@@ -1815,6 +1816,7 @@ const RTK_Settings_Entry rtkSettingsEntries[] =
     { 1, 1, 0, 1, 1, 1, 1, 1, 1, ALL, 1, _bool,     0, & settings.enableNtripCaster, "enableNtripCaster",  },
     { 0, 1, 0, 1, 1, 1, 1, 1, 1, ALL, 1, _bool,     0, & settings.baseCasterOverride, "baseCasterOverride",  },
     { 0, 0, 0, 1, 1, 1, 1, 1, 1, ALL, 1, _bool,     0, & settings.debugCLI, "debugCLI",  },
+    { 0, 0, 0, 1, 1, 1, 1, 1, 1, ALL, 1, _uint16_t, 0, & settings.cliBlePrintDelay_ms, "cliBlePrintDelay_ms",  },
 
 
     // Add new settings to appropriate group above or create new group