Fix CLI

nseidle · nseidle · commit 651a3d4fe7de · 2025-03-10T15:02:34.000-06:00
When function got split out, with a char *cmdBuffer call variable, sizeof(cmdBuffer) no longer applies. This was broken between v1.4 and v2.0.
diff --git a/Firmware/RTK_Everywhere/menuCommands.ino b/Firmware/RTK_Everywhere/menuCommands.ino
@@ -64,7 +64,7 @@ t_cliResult processCommand(char *cmdBuffer)
         }
 
         // Remove $
-        memmove(cmdBuffer, &cmdBuffer[1], sizeof(cmdBuffer) - 1);
+        memmove(cmdBuffer, &cmdBuffer[1], strlen(cmdBuffer));
 
         // Change * to , and null terminate on the first CRC character
         cmdBuffer[strlen(cmdBuffer) - 3] = ',';

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ t_cliResult processCommand(char *cmdBuffer)`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`// Remove $`
`67`		`- memmove(cmdBuffer, &cmdBuffer[1], sizeof(cmdBuffer) - 1);`
	`67`	`+ memmove(cmdBuffer, &cmdBuffer[1], strlen(cmdBuffer));`
`68`	`68`
`69`	`69`	`// Change * to , and null terminate on the first CRC character`
`70`	`70`	`cmdBuffer[strlen(cmdBuffer) - 3] = ',';`