Merge pull request #768 from sparkfun/pcUpdates_configurePPP_web_config

Hide web config configurePPP on non-LG290P platforms

Author: nseidle

Firmware/RTK_Everywhere/AP-Config/index.html

@@ -362,16 +362,18 @@
                                 <span class="icon-info-circle text-primary ms-2"></span>
                             </span>
                         </div>
-                        <div class="form-group row">
-                            <label for="configurePPP" class="box-margin20 col-sm-3 col-5 col-form-label">Configure PPP:
-                                <span class="tt" data-bs-placement="right"
-                                    title="The configuration string for PPP. Enter values separated by spaces, not commas. Default: 2 1 120 0.10 0.15">
-                                    <span class="icon-info-circle text-primary ms-2"></span>
-                                </span>
-                            </label>
-                            <div class="col-sm-8 col-6">
-                                <input type="text" class="form-control" id="configurePPP">
-                                <p id="configurePPPError" class="inlineError"></p>
+                        <div id="configurePppSetting">
+                            <div class="form-group row">
+                                <label for="configurePPP" class="box-margin20 col-sm-3 col-5 col-form-label">Configure PPP:
+                                    <span class="tt" data-bs-placement="right"
+                                        title="The configuration string for PPP. Enter values separated by spaces, not commas. Default: 2 1 120 0.10 0.15">
+                                        <span class="icon-info-circle text-primary ms-2"></span>
+                                    </span>
+                                </label>
+                                <div class="col-sm-8 col-6">
+                                    <input type="text" class="form-control" id="configurePPP">
+                                    <p id="configurePPPError" class="inlineError"></p>
+                                </div>
                             </div>
                         </div>
                     </div>

Firmware/RTK_Everywhere/AP-Config/src/main.js

@@ -226,6 +226,9 @@ function parseIncoming(msg) {
                 hide("constellationSbas"); //Not supported on UM980
                 hide("constellationNavic"); //Not supported on UM980
 
+                show("galileoHasSetting");
+                hide("lg290pGnssSettings");
+
                 show("measurementRateInput");
 
                 show("loraConfig");
@@ -711,6 +714,7 @@ function parseIncoming(msg) {
         ge("enableARPLogging").dispatchEvent(new CustomEvent('change'));
         ge("enableAutoFirmwareUpdate").dispatchEvent(new CustomEvent('change'));
         ge("enableAutoReset").dispatchEvent(new CustomEvent('change'));
+        ge("enableGalileoHas").dispatchEvent(new CustomEvent('change'));
 
         updateECEFList();
         updateGeodeticList();
@@ -876,7 +880,7 @@ function validateFields() {
     if (isElementShown("lg290pGnssSettings") == true) {
         checkElementValue("rtcmMinElev", -90, 90, "Must be between -90 and 90", "collapseGNSSConfig");
     }
-    if (ge("enableGalileoHas").checked == true) {
+    if (isElementShown("configurePppSetting") == true) {
         checkElementStringSpacesNoCommas("configurePPP", 1, 30, "Must be 1 to 30 characters. Separated by spaces. Commas not allowed", "collapseGNSSConfig");
     }
     if (ge("enableNtripClient").checked == true) {
@@ -2006,6 +2010,20 @@ document.addEventListener("DOMContentLoaded", (event) => {
         adjustHAE();
     });
 
+    ge("enableGalileoHas").addEventListener("change", function () {
+        if ((isElementShown("galileoHasSetting") == true) && (isElementShown("lg290pGnssSettings") == true)) {
+            if (ge("enableGalileoHas").checked == true) {
+                show("configurePppSetting");
+            }
+            else {
+                hide("configurePppSetting");
+            }
+        }
+        else {
+            hide("configurePppSetting"); // Hide on Torch UM980 - i.e. non-LG290P
+        }
+    });
+
     for (let y = 0; y < numCorrectionsSources; y++) {
         var buttonName = "corrPrioButton" + y;
         ge(buttonName).addEventListener("click", function () {