Read analog pins as digital to try and avoid SD detection badness

Author: PaulZC

Firmware/RTK_Everywhere/Display.ino

@@ -2499,10 +2499,10 @@ void paintSystemTest()
                 pinMode(pin_muxADC, INPUT_PULLUP);
 
                 digitalWrite(pin_muxDAC, HIGH);
-                if (digitalRead(pin_muxADC) == HIGH)
+                if (readAnalogPinAsDigital(pin_muxADC) == HIGH)
                 {
                     digitalWrite(pin_muxDAC, LOW);
-                    if (digitalRead(pin_muxADC) == LOW)
+                    if (readAnalogPinAsDigital(pin_muxADC) == LOW)
                         oled->print("OK");
                     else
                         oled->print("FAIL");

Firmware/RTK_Everywhere/GNSS_UM980.ino

@@ -1947,9 +1947,9 @@ void um980FirmwareBeginUpdate()
             }
         }
 
-        if (digitalRead(pin_powerButton) == HIGH)
+        if (readAnalogPinAsDigital(pin_powerButton) == HIGH)
         {
-            while (digitalRead(pin_powerButton) == HIGH)
+            while (readAnalogPinAsDigital(pin_powerButton) == HIGH)
                 delay(100);
 
             // Remove file and reset to exit pass-through mode

Firmware/RTK_Everywhere/LoRa.ino

@@ -482,9 +482,9 @@ void beginLoraFirmwareUpdate()
         while (serialGNSS->available())
             Serial.write(serialGNSS->read());
 
-        if (digitalRead(pin_powerButton) == HIGH)
+        if (readAnalogPinAsDigital(pin_powerButton) == HIGH)
         {
-            while (digitalRead(pin_powerButton) == HIGH)
+            while (readAnalogPinAsDigital(pin_powerButton) == HIGH)
                 delay(100);
 
             // Remove file and reset to exit LoRa update pass-through mode

Firmware/RTK_Everywhere/SD.ino

@@ -84,13 +84,13 @@ bool sdCardPresent(void)
 {
     if (present.microSdCardDetectLow == true)
     {
-        if (digitalRead(pin_microSD_CardDetect) == LOW)
+        if (readAnalogPinAsDigital(pin_microSD_CardDetect) == LOW)
             return (true); // Card detect low = SD in place
         return (false);    // Card detect high = No SD
     }
     else if (present.microSdCardDetectHigh == true)
     {
-        if (digitalRead(pin_microSD_CardDetect) == HIGH)
+        if (readAnalogPinAsDigital(pin_microSD_CardDetect) == HIGH)
             return (true); // Card detect high = SD in place
         return (false);    // Card detect low = No SD
     }

Firmware/RTK_Everywhere/System.ino

@@ -770,7 +770,7 @@ bool isUsbAttached()
     {
         if (pin_powerAdapterDetect != PIN_UNDEFINED)
             // Pin goes low when wall adapter is detected
-            if (digitalRead(pin_powerAdapterDetect) == HIGH)
+            if (readAnalogPinAsDigital(pin_powerAdapterDetect) == HIGH)
                 return false;
         return true;
     }