Skip to content

Commit 7f8b4e9

Browse files
committed
Remove settings call backs
This is a new feature that we do not yet implement. These call backs were getting called during Web Config when the full settings CSV was hitting severe delays. This removes the duplicate setting (and delay) of setConstellations().
1 parent 0c83bdc commit 7f8b4e9

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

Firmware/RTK_Everywhere/GNSS.ino

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,10 @@ bool gnssCmdUpdateConstellations(int commandIndex)
442442
if (gnss == nullptr)
443443
return false;
444444

445-
return gnss->setConstellations();
445+
//return gnss->setConstellations();
446+
// setConstellations() can take multiple seconds. Avoid calling during WebConfig
447+
// as this can lead to >10 seconds required for parsing of the incoming settings blob
448+
return true;
446449
}
447450

448451
//----------------------------------------
@@ -453,7 +456,8 @@ bool gnssCmdUpdateMessageRates(int commandIndex)
453456
if (gnss == nullptr)
454457
return false;
455458

456-
return gnss->setMessages(MAX_SET_MESSAGES_RETRIES);
459+
//return gnss->setMessages(MAX_SET_MESSAGES_RETRIES);
460+
return true;
457461
}
458462

459463
//----------------------------------------

0 commit comments

Comments
 (0)