File tree Expand file tree Collapse file tree 2 files changed +0
-11
lines changed Expand file tree Collapse file tree 2 files changed +0
-11
lines changed Original file line number Diff line number Diff line change @@ -252,12 +252,6 @@ bool GNSS_UM980::configureOnce()
252
252
response &= _um980->setPortBaudrate (" COM2" , 115200 ); // COM2 is connected to the IMU
253
253
response &= _um980->setPortBaudrate (" COM3" , 115200 ); // COM3 is connected to the switch, then ESP32
254
254
255
- // TODO: delete Paul's little rant, once you've read it
256
- // Why would you change the COM3 baud rate here? It's connected to the ESP32 serialGNSS. You can't
257
- // change the COM3 baud rate without changing the serialGNSS baud to match... I think this only works
258
- // because there is a "settings.dataPortBaud = 115200; // Override settings. Use UM980 at 115200bps."
259
- // in beginBoard. It causes badness when profile defaults are applied via web config, because that
260
- // sets settings.dataPortBaud back to its default of 230400!
261
255
// // For now, let's not change the baud rate of the interface. We'll be using the default 115200 for now.
262
256
// response &= setBaudRateCOM3(settings.dataPortBaud); // COM3 is connected to ESP UART2
263
257
Original file line number Diff line number Diff line change @@ -2016,11 +2016,6 @@ void createSettingsString(char *newSettings)
2016
2016
}
2017
2017
stringRecord (newSettings, " lastState" , lastState);
2018
2018
2019
- /* This is a duplicate - from olden times? See #719 It's probably not doing any harm. But still... TODO: remove it
2020
- stringRecord(
2021
- newSettings, "profileName",
2022
- profileNames[profileNumber]); // Must come before profile number so AP config page JS has name before number
2023
- */
2024
2019
stringRecord (newSettings, " profileNumber" , profileNumber);
2025
2020
for (int index = 0 ; index < MAX_PROFILE_COUNT; index++)
2026
2021
{
You can’t perform that action at this time.
0 commit comments