Comment the mosaic debug prints - the SBF prints as garbage

PaulZC · PaulZC · commit 893cfc96fd4e · 2025-08-04T18:25:03.000+01:00
diff --git a/Firmware/RTK_Everywhere/GNSS_Mosaic.ino b/Firmware/RTK_Everywhere/GNSS_Mosaic.ino
@@ -2114,8 +2114,8 @@ bool GNSS_MOSAIC::sendAndWaitForIdle(HardwareSerial *serialPort, const char *mes
         if (serialPort->available()) // If a char is available
         {
             uint8_t c = serialPort->read(); // Read it
-            if (debug && (settings.debugGnss == true) && (!inMainMenu))
-                systemPrintf("%c", (char)c);
+            //if (debug && (settings.debugGnss == true) && (!inMainMenu))
+            //    systemPrintf("%c", (char)c);
             if (c == *(reply + replySeen)) // Is it a char from reply?
             {
                 if (response && (replySeen < (responseSize - 1)))
@@ -2138,8 +2138,8 @@ bool GNSS_MOSAIC::sendAndWaitForIdle(HardwareSerial *serialPort, const char *mes
             if (serialPort->available())
             {
                 uint8_t c = serialPort->read();
-                if (debug && (settings.debugGnss == true) && (!inMainMenu))
-                    systemPrintf("%c", (char)c);
+                //if (debug && (settings.debugGnss == true) && (!inMainMenu))
+                //    systemPrintf("%c", (char)c);
                 if (response && (replySeen < (responseSize - 1)))
                 {
                     *(response + replySeen) = c;
@@ -2228,8 +2228,8 @@ bool GNSS_MOSAIC::sendWithResponse(HardwareSerial *serialPort, const char *messa
         if (serialPort->available()) // If a char is available
         {
             uint8_t c = serialPort->read(); // Read it
-            if ((settings.debugGnss == true) && (!inMainMenu))
-                systemPrintf("%c", (char)c);
+            //if ((settings.debugGnss == true) && (!inMainMenu))
+            //    systemPrintf("%c", (char)c);
             if (c == *(reply + replySeen)) // Is it a char from reply?
             {
                 if (response && (replySeen < (responseSize - 1)))
@@ -2260,8 +2260,8 @@ bool GNSS_MOSAIC::sendWithResponse(HardwareSerial *serialPort, const char *messa
             if (serialPort->available())
             {
                 uint8_t c = serialPort->read();
-                if ((settings.debugGnss == true) && (!inMainMenu))
-                    systemPrintf("%c", (char)c);
+                //if ((settings.debugGnss == true) && (!inMainMenu))
+                //    systemPrintf("%c", (char)c);
                 if (response && (replySeen < (responseSize - 1)))
                 {
                     *(response + replySeen) = c;

Original file line number	Diff line number	Diff line change
`@@ -2114,8 +2114,8 @@ bool GNSS_MOSAIC::sendAndWaitForIdle(HardwareSerial serialPort, const char mes`
`2114`	`2114`	`if (serialPort->available()) // If a char is available`
`2115`	`2115`	`{`
`2116`	`2116`	`uint8_t c = serialPort->read(); // Read it`
`2117`		`- if (debug && (settings.debugGnss == true) && (!inMainMenu))`
`2118`		`- systemPrintf("%c", (char)c);`
	`2117`	`+ //if (debug && (settings.debugGnss == true) && (!inMainMenu))`
	`2118`	`+ // systemPrintf("%c", (char)c);`
`2119`	`2119`	`if (c == *(reply + replySeen)) // Is it a char from reply?`
`2120`	`2120`	`{`
`2121`	`2121`	`if (response && (replySeen < (responseSize - 1)))`
`@@ -2138,8 +2138,8 @@ bool GNSS_MOSAIC::sendAndWaitForIdle(HardwareSerial serialPort, const char mes`
`2138`	`2138`	`if (serialPort->available())`
`2139`	`2139`	`{`
`2140`	`2140`	`uint8_t c = serialPort->read();`
`2141`		`- if (debug && (settings.debugGnss == true) && (!inMainMenu))`
`2142`		`- systemPrintf("%c", (char)c);`
	`2141`	`+ //if (debug && (settings.debugGnss == true) && (!inMainMenu))`
	`2142`	`+ // systemPrintf("%c", (char)c);`
`2143`	`2143`	`if (response && (replySeen < (responseSize - 1)))`
`2144`	`2144`	`{`
`2145`	`2145`	`*(response + replySeen) = c;`
`@@ -2228,8 +2228,8 @@ bool GNSS_MOSAIC::sendWithResponse(HardwareSerial serialPort, const char messa`
`2228`	`2228`	`if (serialPort->available()) // If a char is available`
`2229`	`2229`	`{`
`2230`	`2230`	`uint8_t c = serialPort->read(); // Read it`
`2231`		`- if ((settings.debugGnss == true) && (!inMainMenu))`
`2232`		`- systemPrintf("%c", (char)c);`
	`2231`	`+ //if ((settings.debugGnss == true) && (!inMainMenu))`
	`2232`	`+ // systemPrintf("%c", (char)c);`
`2233`	`2233`	`if (c == *(reply + replySeen)) // Is it a char from reply?`
`2234`	`2234`	`{`
`2235`	`2235`	`if (response && (replySeen < (responseSize - 1)))`
`@@ -2260,8 +2260,8 @@ bool GNSS_MOSAIC::sendWithResponse(HardwareSerial serialPort, const char messa`
`2260`	`2260`	`if (serialPort->available())`
`2261`	`2261`	`{`
`2262`	`2262`	`uint8_t c = serialPort->read();`
`2263`		`- if ((settings.debugGnss == true) && (!inMainMenu))`
`2264`		`- systemPrintf("%c", (char)c);`
	`2263`	`+ //if ((settings.debugGnss == true) && (!inMainMenu))`
	`2264`	`+ // systemPrintf("%c", (char)c);`
`2265`	`2265`	`if (response && (replySeen < (responseSize - 1)))`
`2266`	`2266`	`{`
`2267`	`2267`	`*(response + replySeen) = c;`