Don't delete mqttSecureClient - see below:

PaulZC · PaulZC · commit 9d56cd47aaa1 · 2024-06-13T16:52:04.000+01:00
This prevents the crash reported in #335. My theory is: mqttClient uses mqttSecureClient When we delete mqttClient, we are possibly also deleting mqttSecureClient but the pointer isn't getting set to NULL I'll investigate...
diff --git a/Firmware/RTK_Everywhere/MQTT_Client.ino b/Firmware/RTK_Everywhere/MQTT_Client.ino
@@ -443,7 +443,7 @@ void mqttClientStop(bool shutdown)
     {
         if (settings.debugMqttClientState)
             systemPrintln("Freeing mqttSecureClient");
-        delete mqttSecureClient;
+        //delete mqttSecureClient;
         mqttSecureClient = nullptr;
         reportHeapNow(settings.debugMqttClientState);
     }

Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,7 @@ void mqttClientStop(bool shutdown)`
`443`	`443`	`{`
`444`	`444`	`if (settings.debugMqttClientState)`
`445`	`445`	`systemPrintln("Freeing mqttSecureClient");`
`446`		`- delete mqttSecureClient;`
	`446`	`+ //delete mqttSecureClient;`
`447`	`447`	`mqttSecureClient = nullptr;`
`448`	`448`	`reportHeapNow(settings.debugMqttClientState);`
`449`	`449`	`}`