Skip to content

Commit bb24444

Browse files
committed
Add comments about where stuff is freed
1 parent 57108fa commit bb24444

File tree

3 files changed

+4
-0
lines changed

3 files changed

+4
-0
lines changed

Firmware/RTK_Everywhere/Begin.ino

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -671,6 +671,7 @@ void beginGnssUart()
671671
length = settings.gnssHandlerBufferSize + (rbOffsetEntries * sizeof(RING_BUFFER_OFFSET));
672672
ringBuffer = nullptr;
673673

674+
// Never freed...
674675
if (rbOffsetArray == nullptr)
675676
{
676677
if (online.psram == true)

Firmware/RTK_Everywhere/Form.ino

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,7 @@ bool startWebServer(bool startWiFi = true, int httpPort = 80)
271271
MDNS.addService("http", "tcp", 80); // Add service to MDNS-SD
272272
}
273273

274+
// Freed by stopWebServer
274275
if (online.psram == true)
275276
incomingSettings = (char *)ps_malloc(AP_CONFIG_SETTING_SIZE);
276277
else
@@ -284,6 +285,7 @@ bool startWebServer(bool startWiFi = true, int httpPort = 80)
284285
memset(incomingSettings, 0, AP_CONFIG_SETTING_SIZE);
285286

286287
// Pre-load settings CSV
288+
// Freed by stopWebServer
287289
if (online.psram == true)
288290
settingsCSV = (char *)ps_malloc(AP_CONFIG_SETTING_SIZE);
289291
else

Firmware/RTK_Everywhere/PointPerfectLibrary.ino

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ void beginPPL()
132132
reportHeapNow(false);
133133

134134
// PPL_MAX_RTCM_BUFFER is 3345 bytes so we create it on the heap
135+
// Freed by stopPPL()
135136
if (pplRtcmBuffer == nullptr)
136137
{
137138
if (online.psram == true)

0 commit comments

Comments
 (0)