Do not set callback to nullptr

nseidle · nseidle · commit c142ce861b35 · 2024-07-22T10:45:04.000-06:00
When radio disconnects(), it calls the callback, and if its set to nullptr, ESP32 resets.
diff --git a/Firmware/RTK_Everywhere/Bluetooth.ino b/Firmware/RTK_Everywhere/Bluetooth.ino
@@ -435,26 +435,22 @@ void bluetoothStop()
     {
         if (settings.bluetoothRadioType == BLUETOOTH_RADIO_SPP_AND_BLE)
         {
-            bluetoothSerialBle->register_callback(nullptr);
             bluetoothSerialBle->flush(); // Complete any transfers
             bluetoothSerialBle->disconnect(); // Drop any clients
             bluetoothSerialBle->end(); // Release resources
 
-            bluetoothSerialSpp->register_callback(nullptr);
             bluetoothSerialSpp->flush(); // Complete any transfers
             bluetoothSerialSpp->disconnect(); // Drop any clients
             bluetoothSerialSpp->end(); // Release resources
         }
         else if (settings.bluetoothRadioType == BLUETOOTH_RADIO_SPP)
         {
-            bluetoothSerialSpp->register_callback(nullptr);
             bluetoothSerialSpp->flush(); // Complete any transfers
             bluetoothSerialSpp->disconnect(); // Drop any clients
             bluetoothSerialSpp->end(); // Release resources
         }
         else if (settings.bluetoothRadioType == BLUETOOTH_RADIO_BLE)
         {
-            bluetoothSerialBle->register_callback(nullptr);
             bluetoothSerialBle->flush(); // Complete any transfers
             bluetoothSerialBle->disconnect(); // Drop any clients
             bluetoothSerialBle->end(); // Release resources

Original file line number	Diff line number	Diff line change
`@@ -435,26 +435,22 @@ void bluetoothStop()`
`435`	`435`	`{`
`436`	`436`	`if (settings.bluetoothRadioType == BLUETOOTH_RADIO_SPP_AND_BLE)`
`437`	`437`	`{`
`438`		`- bluetoothSerialBle->register_callback(nullptr);`
`439`	`438`	`bluetoothSerialBle->flush(); // Complete any transfers`
`440`	`439`	`bluetoothSerialBle->disconnect(); // Drop any clients`
`441`	`440`	`bluetoothSerialBle->end(); // Release resources`
`442`	`441`
`443`		`- bluetoothSerialSpp->register_callback(nullptr);`
`444`	`442`	`bluetoothSerialSpp->flush(); // Complete any transfers`
`445`	`443`	`bluetoothSerialSpp->disconnect(); // Drop any clients`
`446`	`444`	`bluetoothSerialSpp->end(); // Release resources`
`447`	`445`	`}`
`448`	`446`	`else if (settings.bluetoothRadioType == BLUETOOTH_RADIO_SPP)`
`449`	`447`	`{`
`450`		`- bluetoothSerialSpp->register_callback(nullptr);`
`451`	`448`	`bluetoothSerialSpp->flush(); // Complete any transfers`
`452`	`449`	`bluetoothSerialSpp->disconnect(); // Drop any clients`
`453`	`450`	`bluetoothSerialSpp->end(); // Release resources`
`454`	`451`	`}`
`455`	`452`	`else if (settings.bluetoothRadioType == BLUETOOTH_RADIO_BLE)`
`456`	`453`	`{`
`457`		`- bluetoothSerialBle->register_callback(nullptr);`
`458`	`454`	`bluetoothSerialBle->flush(); // Complete any transfers`
`459`	`455`	`bluetoothSerialBle->disconnect(); // Drop any clients`
`460`	`456`	`bluetoothSerialBle->end(); // Release resources`