Revert aclConnected to a one-shot

Author: PaulZC

Firmware/RTK_Everywhere/AuthCoPro.ino

@@ -89,7 +89,9 @@ void updateAuthCoPro()
             appleAccessory->update(); // Update the Accessory driver
 
             // Check for a new device connection
-            if (bluetoothSerialSpp->aclConnected() == true && bluetoothSerialSpp->connected() == false)
+            // Note: aclConnected is a one-shot
+            //       The internal flag is automatically cleared when aclConnected returns true
+            if (bluetoothSerialSpp->aclConnected() == true)
             {
                 // //
                 // https://github.com/espressif/arduino-esp32/blob/master/libraries/BluetoothSerial/examples/DiscoverConnect/DiscoverConnect.ino

Firmware/RTK_Everywhere/src/BluetoothSerial/BluetoothSerial.cpp

@@ -381,10 +381,6 @@ static void esp_spp_cb(esp_spp_cb_event_t event, esp_spp_cb_param_t *param)
             log_e("ESP_SPP_CLOSE_EVT failed!, status:%d", param->close.status);
         }
 
-        //The ESP_BT_GAP_ACL_DISCONN_CMPL_STAT_EVT event can take awhile. Mark ACL disconnected here as well.
-        memset(_aclAddress, 0, ESP_BD_ADDR_LEN);
-        _aclConnected = false;
-
         break;
 
     case ESP_SPP_START_EVT: // Enum 28 - When SPP server started
@@ -749,9 +745,6 @@ static void esp_bt_gap_cb(esp_bt_gap_cb_event_t event, esp_bt_gap_cb_param_t *pa
     case ESP_BT_GAP_ACL_DISCONN_CMPL_STAT_EVT: // Enum 17 - ACL disconnection complete status event
         log_i("ESP_BT_GAP_ACL_DISCONN_CMPL_STAT_EVT ACL disconnection complete status event: reason %d, handle %d",
               param->acl_disconn_cmpl_stat.reason, param->acl_disconn_cmpl_stat.handle);
-
-        memset(_aclAddress, 0, ESP_BD_ADDR_LEN);
-        _aclConnected = false;
         break;
 
 #if false
@@ -1719,9 +1712,16 @@ void BluetoothSerial::deleteAllBondedDevices()
     }
 }
 
+// aclConnected() is a one-shot. __aclConnected is cleared when returning true
 bool BluetoothSerial::aclConnected()
 {
-    return (_aclConnected);
+    if (_aclConnected)
+    {
+        _aclConnected = false;
+        return true;
+    }
+
+    return false;
 }
 
 uint8_t *BluetoothSerial::aclGetAddress()

Firmware/RTK_Everywhere/src/BluetoothSerial/BluetoothSerial.h

@@ -114,7 +114,7 @@ class BluetoothSerial : public Stream {
   bool deleteBondedDevice(uint8_t *remoteAddress);
   void deleteAllBondedDevices();
 
-  bool aclConnected();
+  bool aclConnected(); // One-shot
   uint8_t *aclGetAddress();
 
 private: