Fix over-use of prioritySettingsEnd

PaulZC · PaulZC · commit d7eefd8a5939 · 2025-09-23T18:13:38.000+01:00
diff --git a/Firmware/RTK_Everywhere/menuCommands.ino b/Firmware/RTK_Everywhere/menuCommands.ino
@@ -3789,15 +3789,17 @@ int adjustEndOfPrioritySettings(int prioritySettingsEnd)
     if (prioritySettingsEnd == 0)
         return 0;
 
+    int adjustedPrioritySettingsEnd = prioritySettingsEnd;
+
     // Check which of the priority settings are possible on this platform
     // Deduct the ones which are not
     for (int i = 0; i < prioritySettingsEnd; i++)
     {
         if (!settingPossibleOnPlatform(i))
-            prioritySettingsEnd--;
+            adjustedPrioritySettingsEnd--;
     }
 
-    return prioritySettingsEnd;
+    return adjustedPrioritySettingsEnd;
 }
 
 // Allocate and fill the commandIndex table

Original file line number	Diff line number	Diff line change
`@@ -3789,15 +3789,17 @@ int adjustEndOfPrioritySettings(int prioritySettingsEnd)`
`3789`	`3789`	`if (prioritySettingsEnd == 0)`
`3790`	`3790`	`return 0;`
`3791`	`3791`
	`3792`	`+ int adjustedPrioritySettingsEnd = prioritySettingsEnd;`
	`3793`	`+`
`3792`	`3794`	`// Check which of the priority settings are possible on this platform`
`3793`	`3795`	`// Deduct the ones which are not`
`3794`	`3796`	`for (int i = 0; i < prioritySettingsEnd; i++)`
`3795`	`3797`	`{`
`3796`	`3798`	`if (!settingPossibleOnPlatform(i))`
`3797`		`- prioritySettingsEnd--;`
	`3799`	`+ adjustedPrioritySettingsEnd--;`
`3798`	`3800`	`}`
`3799`	`3801`
`3800`		`- return prioritySettingsEnd;`
	`3802`	`+ return adjustedPrioritySettingsEnd;`
`3801`	`3803`	`}`
`3802`	`3804`
`3803`	`3805`	`// Allocate and fill the commandIndex table`