Base (e.g. Survey-In) icons missing on 128x64 OLED

[PaulZC]

As reported in #792

EVK does not display the chequered flag survey-in icon, or the castle fixed base icon. The same is probably true on Postcard.

[PaulZC]

Ah. Silly copy-paste error here:

SparkFun_RTK_Everywhere_Firmware/Firmware/RTK_Everywhere/icons.h

Lines 1904 to 1907 in 1cce7c8

	const iconProperties BaseTemporaryProperties = {{{ &BaseTemporary, BaseTemporary_Width, BaseTemporary_Height, BaseIconXPos64x48, BaseIconYPos64x48 },
	{ &BaseTemporary, BaseTemporary_Width, BaseTemporary_Height, BaseIconXPos128x64, BaseIconXPos128x64 }}};
	const iconProperties BaseFixedProperties = {{{ &BaseFixed, BaseTemporary_Width, BaseTemporary_Height, BaseIconXPos64x48, BaseIconYPos64x48 },
	{ &BaseFixed, BaseTemporary_Width, BaseTemporary_Height, BaseIconXPos128x64, BaseIconXPos128x64 }}};

BaseIconXPos128x64 should be BaseIconYPos128x64 in two places:

const iconProperties BaseTemporaryProperties = {{{ &BaseTemporary, BaseTemporary_Width, BaseTemporary_Height, BaseIconXPos64x48, BaseIconYPos64x48 },
                                                 { &BaseTemporary, BaseTemporary_Width, BaseTemporary_Height, BaseIconXPos128x64, BaseIconYPos128x64 }}};
const iconProperties BaseFixedProperties = {{{ &BaseFixed, BaseTemporary_Width, BaseTemporary_Height, BaseIconXPos64x48, BaseIconYPos64x48 },
                                              { &BaseFixed, BaseTemporary_Width, BaseTemporary_Height, BaseIconXPos128x64, BaseIconYPos128x64 }}};

[PaulZC]

This will be resolved by #803