Gracefully fail when firmware update fails. Fix for issue 66.

Author: nseidle

Firmware/RTK_Surveyor/Form.ino

@@ -428,7 +428,10 @@ void updateSettingWithValue(const char *settingName, const char* settingValueStr
 
   //Special actions
   else if (strcmp(settingName, "firmwareFileName") == 0)
+  {
     updateFromSD(settingValueStr);
+    requestChangeState(STATE_ROVER_NOT_STARTED); //If update failed, return to Rover mode.
+  }
   else if (strcmp(settingName, "factoryDefaultReset") == 0)
     factoryReset();
   else if (strcmp(settingName, "exitToRoverMode") == 0)

Firmware/RTK_Surveyor/RTK_Surveyor.ino

@@ -511,7 +511,7 @@ void updateLogs()
         }
         else
         {
-          ESP_LOGD(TAG, "Log file: No increase in file size");
+          ESP_LOGD(TAG, "No increase in file size");
           logIncreasing = false;
         }
       }

Firmware/RTK_Surveyor/menuFirmware.ino

@@ -182,7 +182,7 @@ void updateFromSD(const char *firmwareFileName)
       if (Update.isFinished())
       {
         displayFirmwareUpdateProgress(100);
-        
+
         Serial.println(F("Firmware updated successfully. Rebooting. Good bye!"));
 
         //If forced firmware is detected, do a full reset of config as well
@@ -220,6 +220,10 @@ void updateFromSD(const char *firmwareFileName)
     }
 
     firmwareFile.close();
+
+    displayMessage("Update Failed", 0);
+
+    Serial.println(F("Firmware update failed. Please try again."));
   }
   else
   {