-
Notifications
You must be signed in to change notification settings - Fork 3
First Release #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
First Release #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for some OpenCV functions Converts to ndarray_obj_t to handle all possible input types
Some OpenCV functions need these Also improve conversion to cv:Size
For some reason, putText() doubles the flash requirement, from roughly 2.4MB to 4.8MB. The RP2350 linker script hard codes the flash size at 4MB, so have to modify that to get it to link properly. Even after that, putText() had a weird output. Commented out for now.
These already exist in ulab numpy as minimum() and maximum(). Removing helps keep the firmware a bit smaller without losing any functionality.
HoughLinesP uses int32 for the output array, which ulab currenltly does not support. Commented out for now.
Mostly just for compatibility with existing OpenCV code
Based on feedback in #7
Needed for new ST7789 implementation to convert other dtypes
Create helper functions for imshow() (could move these to a generic interface class for other display drivers to take advantage of) Move machine dependency from example to display driver Add extra checks for edge cases Remove unused functions and arguments Add clear() method Fix imshow() with float images to clip instead of wrap the range 0-1 Other minor optimizations
Add imshow() and waitKey()
Workaround for raspberrypi/pico-sdk#2505 Fixes #12
Fixes a couple issues, see v923z/micropython-ulab#724 and v923z/micropython-ulab#725
Rename "test_image" to "images" since they're already in the examples folder Updated paths in imread imwrite example Fixed cv2_hardware_init/__init__.py to use full path to new example splash image
Replaced by splash.png
18c4039 changed the examples folder name
Feature/build release
Add splash image Update Quick Start section now that examples are frozen into the firmware Condense example code snippets Re-organize supported hardware list as tables with emojis
Uncomment drive functions Also rename to "touch_screen_drive"
Some general CommentsBrandingHow is branding being reflected? PackageFor the directory structure for our micropython code? Should I would expect the end user to do something like this to get going: import redvision as rv
# do amazing things
rv.do_amazing_things(mydata) Package / Firmware VersionAnd for the firmware version -
Drivers
|
Refactor for #42 Also move submodules out of src directory
gigapod
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots to review 😉
Depends on #38