Skip to content

Commit 9274f80

Browse files
committed
esp32/boards/ESP32_GENERIC_S3: Reinstate old FLASH_4M variant.
Commit 6201e77 removed the ESP32_GENERIC_S3 FLASH_4M variant from `board.json`. But the firmware still exists on the download server, and it makes sense to still keep those old versions available for download, just like all other older versions are still available. This commit introduce a new scheme for `board.json` whereby old variants that are no longer built can be moved to the "old_variants" section. This keeps them available on the download page, allowing a way to deprecate individual board variants without removing them entirely. An optional string can be added to the old variant to describe why it's obsolete and what to use instead. Signed-off-by: Damien George <[email protected]>
1 parent 099cc9f commit 9274f80

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

ports/esp32/boards/ESP32_GENERIC_S3/board.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,8 @@
2222
"vendor": "Espressif",
2323
"variants": {
2424
"SPIRAM_OCT": "Support for Octal-SPIRAM"
25+
},
26+
"old_variants": {
27+
"FLASH_4M": ["4MiB flash", "Use the standard variant instead."]
2528
}
2629
}

0 commit comments

Comments
 (0)