Skip to content

Commit c1c73d9

Browse files
agattidpgeorge
andcommitted
tests/run-tests.py: Unconditionally enable native tests if asked.
This commit lets the test runner enumerate and run native tests if the feature check fails but native tests were explicitly requested from the command line. The old behaviour would disable native tests anyway if the feature check failed, however this hid a bug in the x86 native emitter that would be triggered even during the feature check. That meant the test suite would pass on x86 even with a broken emitter, as those tests would have been skipped anyway. Now, if the user asks for native code it will get native code out of the runner no matter what. Co-authored-by: Damien George <[email protected]> Signed-off-by: Alessandro Gatti <[email protected]>
1 parent 5b90d6d commit c1c73d9

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

tests/run-tests.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -875,11 +875,7 @@ def run_one_test(test_file):
875875

876876
test_basename = test_file.replace("..", "_").replace("./", "").replace("/", "_")
877877
test_name = os.path.splitext(os.path.basename(test_file))[0]
878-
is_native = (
879-
test_name.startswith("native_")
880-
or test_name.startswith("viper_")
881-
or args.emit == "native"
882-
)
878+
is_native = test_name.startswith("native_") or test_name.startswith("viper_")
883879
is_endian = test_name.endswith("_endian")
884880
is_int_big = test_name.startswith("int_big") or test_name.endswith("_intbig")
885881
is_bytearray = test_name.startswith("bytearray") or test_name.endswith("_bytearray")

0 commit comments

Comments
 (0)