Skip to content

Rigorously check for HTTPS when handling secure cookies #12

@vilmibm

Description

@vilmibm

Checking that the uri instance descends from URI::HTTPS is insufficient:

return false if secure? && !(URI::HTTPS === uri)

Instead, this needs to check the actual scheme of the uri instance (or something else more meaningful). Faraday, for example, uses a URI::HTTP instance with scheme set to https for its secure connections and as a result can't work with this library and secure cookies.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions